threads / patch / 53509

patchcommand-list.txt: add gitfaq to the list of guides

Subject: [PATCH] command-list.txt: add gitfaq to the list of guides

## tl;dr

3 messages between May 20, 2020 and May 21, 2020. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Philippe Blain via GitGitGadget· May 20, 2020, 14:44 UTC · lore

From: Philippe Blain <levraiphilippeblain@gmail.com>

When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30), it was added to the Makefile but not to command-list.txt.

Add it there also, so that the new FAQ is listed in the output of `git help --guides`.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
    command-list.txt: add gitfaq to the list of guides
    
    The new FAQ is not listed in command-list.txt, so it does not show up in 
    git help --guides.
    
    I think this should be included in 2.27.0.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-639%2Fphil-blain%2Flist-faq-in-guides-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-639/phil-blain/list-faq-in-guides-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/639

 command-list.txt | 1 +
 1 file changed, 1 insertion(+)

Show changes to command-list.txt +1 −0

diff --git a/command-list.txt b/command-list.txt
index 185e5e3f05f..cbb960c8436 100644
--- a/command-list.txt
+++ b/command-list.txt
@@ -198,6 +198,7 @@ gitcore-tutorial                        guide
 gitcvs-migration                        guide
 gitdiffcore                             guide
 giteveryday                             guide
+gitfaq                                  guide
 gitglossary                             guide
 githooks                                guide
 gitignore                               guide

base-commit: efcab5b7a3d2ce2ae4bf808b335938098b18d960

-- 
gitgitgadget

Junio C Hamano· May 20, 2020, 15:54 UTC · re: Philippe Blain via GitGitGadget · lore

Re: [PATCH] command-list.txt: add gitfaq to the list of guides

"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

> From: Philippe Blain <levraiphilippeblain@gmail.com>
>
> When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),
> it was added to the Makefile but not to command-list.txt.
>
> Add it there also, so that the new FAQ is listed in the output of
> `git help --guides`.

Thanks for sharp eyes.

Will queue, but it may be post -rc1.

brian m. carlson· May 21, 2020, 01:53 UTC · re: Philippe Blain via GitGitGadget · lore

Re: [PATCH] command-list.txt: add gitfaq to the list of guides

On 2020-05-20 at 14:44:48, Philippe Blain via GitGitGadget wrote:

Show 7 quoted lines

> From: Philippe Blain <levraiphilippeblain@gmail.com>
> 
> When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),
> it was added to the Makefile but not to command-list.txt.
> 
> Add it there also, so that the new FAQ is listed in the output of
> `git help --guides`.

Thanks for catching this.  This seems obviously correct.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204