{"thread":{"id":"53509","subject":"[PATCH] command-list.txt: add gitfaq to the list of guides","startedAt":"2020-05-20T14:44:53Z","lastAt":"2020-05-21T01:53:31Z","messageCount":3,"participants":["Philippe Blain via GitGitGadget","Junio C Hamano","brian m. carlson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"398256","messageId":"pull.639.git.1589985889076.gitgitgadget@gmail.com","threadId":"53509","inReplyTo":null,"subject":"[PATCH] command-list.txt: add gitfaq to the list of guides","fromName":"Philippe Blain via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-05-20T14:44:48Z","receivedAt":"2020-05-20T14:44:53Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"From: Philippe Blain <levraiphilippeblain@gmail.com>\n\nWhen 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),\nit was added to the Makefile but not to command-list.txt.\n\nAdd it there also, so that the new FAQ is listed in the output of\n`git help --guides`.\n\nSigned-off-by: Philippe Blain <levraiphilippeblain@gmail.com>\n---\n    command-list.txt: add gitfaq to the list of guides\n    \n    The new FAQ is not listed in command-list.txt, so it does not show up in \n    git help --guides.\n    \n    I think this should be included in 2.27.0.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-639%2Fphil-blain%2Flist-faq-in-guides-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-639/phil-blain/list-faq-in-guides-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/639\n\n command-list.txt | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/command-list.txt b/command-list.txt\nindex 185e5e3f05f..cbb960c8436 100644\n--- a/command-list.txt\n+++ b/command-list.txt\n@@ -198,6 +198,7 @@ gitcore-tutorial                        guide\n gitcvs-migration                        guide\n gitdiffcore                             guide\n giteveryday                             guide\n+gitfaq                                  guide\n gitglossary                             guide\n githooks                                guide\n gitignore                               guide\n\nbase-commit: efcab5b7a3d2ce2ae4bf808b335938098b18d960\n-- \ngitgitgadget\n"},{"id":"398262","messageId":"xmqqimgqwqif.fsf@gitster.c.googlers.com","threadId":"53509","inReplyTo":"pull.639.git.1589985889076.gitgitgadget@gmail.com","subject":"Re: [PATCH] command-list.txt: add gitfaq to the list of guides","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-05-20T15:54:48Z","receivedAt":"2020-05-20T15:54:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Philippe Blain via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Philippe Blain <levraiphilippeblain@gmail.com>\n>\n> When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),\n> it was added to the Makefile but not to command-list.txt.\n>\n> Add it there also, so that the new FAQ is listed in the output of\n> `git help --guides`.\n\nThanks for sharp eyes.\n\nWill queue, but it may be post -rc1.\n\n"},{"id":"398317","messageId":"20200521015319.GU6362@camp.crustytoothpaste.net","threadId":"53509","inReplyTo":"pull.639.git.1589985889076.gitgitgadget@gmail.com","subject":"Re: [PATCH] command-list.txt: add gitfaq to the list of guides","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2020-05-21T01:53:19Z","receivedAt":"2020-05-21T01:53:31Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2020-05-20 at 14:44:48, Philippe Blain via GitGitGadget wrote:\n> From: Philippe Blain <levraiphilippeblain@gmail.com>\n> \n> When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),\n> it was added to the Makefile but not to command-list.txt.\n> \n> Add it there also, so that the new FAQ is listed in the output of\n> `git help --guides`.\n\nThanks for catching this.  This seems obviously correct.\n-- \nbrian m. carlson: Houston, Texas, US\nOpenPGP: https://keybase.io/bk2204\n"}]}