# [PATCH] command-list.txt: add gitfaq to the list of guides

3 messages from 2020-05-20 to 2020-05-21. Participants: Philippe Blain via GitGitGadget, Junio C Hamano, brian m. carlson.
Thread: https://gitlist.dev/t/53509

## Philippe Blain via GitGitGadget, 2020-05-20 14:44

Subject: [PATCH] command-list.txt: add gitfaq to the list of guides
Message-ID: <pull.639.git.1589985889076.gitgitgadget@gmail.com>
URL: https://gitlist.dev/e/pull.639.git.1589985889076.gitgitgadget%40gmail.com

```
From: Philippe Blain <levraiphilippeblain@gmail.com>

When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),
it was added to the Makefile but not to command-list.txt.

Add it there also, so that the new FAQ is listed in the output of
`git help --guides`.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
    command-list.txt: add gitfaq to the list of guides
    
    The new FAQ is not listed in command-list.txt, so it does not show up in 
    git help --guides.
    
    I think this should be included in 2.27.0.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-639%2Fphil-blain%2Flist-faq-in-guides-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-639/phil-blain/list-faq-in-guides-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/639

 command-list.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/command-list.txt b/command-list.txt
index 185e5e3f05f..cbb960c8436 100644
--- a/command-list.txt
+++ b/command-list.txt
@@ -198,6 +198,7 @@ gitcore-tutorial                        guide
 gitcvs-migration                        guide
 gitdiffcore                             guide
 giteveryday                             guide
+gitfaq                                  guide
 gitglossary                             guide
 githooks                                guide
 gitignore                               guide

base-commit: efcab5b7a3d2ce2ae4bf808b335938098b18d960
-- 
gitgitgadget

```

## Junio C Hamano, 2020-05-20 15:54

Subject: Re: [PATCH] command-list.txt: add gitfaq to the list of guides
Message-ID: <xmqqimgqwqif.fsf@gitster.c.googlers.com>
URL: https://gitlist.dev/e/xmqqimgqwqif.fsf%40gitster.c.googlers.com
In-Reply-To: <pull.639.git.1589985889076.gitgitgadget@gmail.com>

```
"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Philippe Blain <levraiphilippeblain@gmail.com>
>
> When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),
> it was added to the Makefile but not to command-list.txt.
>
> Add it there also, so that the new FAQ is listed in the output of
> `git help --guides`.

Thanks for sharp eyes.

Will queue, but it may be post -rc1.


```

## brian m. carlson, 2020-05-21 01:53

Subject: Re: [PATCH] command-list.txt: add gitfaq to the list of guides
Message-ID: <20200521015319.GU6362@camp.crustytoothpaste.net>
URL: https://gitlist.dev/e/20200521015319.GU6362%40camp.crustytoothpaste.net
In-Reply-To: <pull.639.git.1589985889076.gitgitgadget@gmail.com>

```
On 2020-05-20 at 14:44:48, Philippe Blain via GitGitGadget wrote:
> From: Philippe Blain <levraiphilippeblain@gmail.com>
> 
> When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),
> it was added to the Makefile but not to command-list.txt.
> 
> Add it there also, so that the new FAQ is listed in the output of
> `git help --guides`.

Thanks for catching this.  This seems obviously correct.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

```