threads / patch / 53443

patchRe: [PATCH] contrib/git-jump: cat output when not a terminal

Subject: Re: [PATCH] contrib/git-jump: cat output when not a terminal

## tl;dr

2 messages between May 10, 2020 and May 11, 2020. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Benjamin· May 10, 2020, 20:26 UTC · lore

Junio writes:

> I somehow doubt that users of vim types "!git jump diff" (or
> whichever submode they want) from within vim's command prompt;
> wouldn't they typically wrap the invocation in a vim macro?

Vim-user here. I run "git jump (options)" from a shell quite a bit, but when I'm in vim I tend to use ":Ggrep" and similar commands from the fugitive plugin [1]. I don't *think* I'm alone in this.

I'm not really arguing either side, just pointing out that other workflows exist (and indeed, I'm unlikely to run ":!git jump diff").

[1]: https://github.com/tpope/vim-fugitive

D. Ben Knoble

Junio C Hamano· May 11, 2020, 14:33 UTC · re: Benjamin · lore

Benjamin <ben.knoble@gmail.com> writes:

Show 9 quoted lines

> Junio writes:
>
>> I somehow doubt that users of vim types "!git jump diff" (or
>> whichever submode they want) from within vim's command prompt;
>> wouldn't they typically wrap the invocation in a vim macro?
>
> Vim-user here. I run "git jump (options)" from a shell quite a bit, but when I'm
> in vim I tend to use ":Ggrep" and similar commands from the fugitive plugin [1].
> I don't *think* I'm alone in this.

I can believe there are tons of users of the plugin. My point still stands---such a plugin can export GIT_EDITOR=cat when running "git jump" and there is no need to change "git jump".