# Re: [PATCH] contrib/git-jump: cat output when not a terminal

2 messages from 2020-05-10 to 2020-05-11. Participants: Benjamin, Junio C Hamano.
Thread: https://gitlist.dev/t/53443

## Benjamin, 2020-05-10 20:26

Subject: Re: [PATCH] contrib/git-jump: cat output when not a terminal
Message-ID: <4CFBC77A-6518-4BEE-A210-6A7C818B9738@gmail.com>
URL: https://gitlist.dev/e/4CFBC77A-6518-4BEE-A210-6A7C818B9738%40gmail.com

```
Junio writes:

> I somehow doubt that users of vim types "!git jump diff" (or
> whichever submode they want) from within vim's command prompt;
> wouldn't they typically wrap the invocation in a vim macro?

Vim-user here. I run "git jump (options)" from a shell quite a bit, but when I'm
in vim I tend to use ":Ggrep" and similar commands from the fugitive plugin [1].
I don't *think* I'm alone in this.

I'm not really arguing either side, just pointing out that other workflows exist
(and indeed, I'm unlikely to run ":!git jump diff").

[1]: https://github.com/tpope/vim-fugitive

D. Ben Knoble
```

## Junio C Hamano, 2020-05-11 14:33

Subject: Re: [PATCH] contrib/git-jump: cat output when not a terminal
Message-ID: <xmqq1rnqtubn.fsf@gitster.c.googlers.com>
URL: https://gitlist.dev/e/xmqq1rnqtubn.fsf%40gitster.c.googlers.com
In-Reply-To: <4CFBC77A-6518-4BEE-A210-6A7C818B9738@gmail.com>

```
Benjamin <ben.knoble@gmail.com> writes:

> Junio writes:
>
>> I somehow doubt that users of vim types "!git jump diff" (or
>> whichever submode they want) from within vim's command prompt;
>> wouldn't they typically wrap the invocation in a vim macro?
>
> Vim-user here. I run "git jump (options)" from a shell quite a bit, but when I'm
> in vim I tend to use ":Ggrep" and similar commands from the fugitive plugin [1].
> I don't *think* I'm alone in this.

I can believe there are tons of users of the plugin.  My point still
stands---such a plugin can export GIT_EDITOR=cat when running "git
jump" and there is no need to change "git jump".

```