{"thread":{"id":"53443","subject":"Re: [PATCH] contrib/git-jump: cat output when not a terminal","startedAt":"2020-05-10T20:26:37Z","lastAt":"2020-05-11T14:33:37Z","messageCount":2,"participants":["Benjamin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"397516","messageId":"4CFBC77A-6518-4BEE-A210-6A7C818B9738@gmail.com","threadId":"53443","inReplyTo":null,"subject":"Re: [PATCH] contrib/git-jump: cat output when not a terminal","fromName":"Benjamin","fromEmail":"ben.knoble@gmail.com","sentAt":"2020-05-10T20:26:33Z","receivedAt":"2020-05-10T20:26:37Z","isPatch":true,"sender":{"key":"ben.knoble@gmail.com","avatar":"https://avatars.githubusercontent.com/u/22802209?v=4"},"body":"Junio writes:\n\n> I somehow doubt that users of vim types \"!git jump diff\" (or\n> whichever submode they want) from within vim's command prompt;\n> wouldn't they typically wrap the invocation in a vim macro?\n\nVim-user here. I run \"git jump (options)\" from a shell quite a bit, but when I'm\nin vim I tend to use \":Ggrep\" and similar commands from the fugitive plugin [1].\nI don't *think* I'm alone in this.\n\nI'm not really arguing either side, just pointing out that other workflows exist\n(and indeed, I'm unlikely to run \":!git jump diff\").\n\n[1]: https://github.com/tpope/vim-fugitive\n\nD. Ben Knoble"},{"id":"397549","messageId":"xmqq1rnqtubn.fsf@gitster.c.googlers.com","threadId":"53443","inReplyTo":"4CFBC77A-6518-4BEE-A210-6A7C818B9738@gmail.com","subject":"Re: [PATCH] contrib/git-jump: cat output when not a terminal","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-05-11T14:33:32Z","receivedAt":"2020-05-11T14:33:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Benjamin <ben.knoble@gmail.com> writes:\n\n> Junio writes:\n>\n>> I somehow doubt that users of vim types \"!git jump diff\" (or\n>> whichever submode they want) from within vim's command prompt;\n>> wouldn't they typically wrap the invocation in a vim macro?\n>\n> Vim-user here. I run \"git jump (options)\" from a shell quite a bit, but when I'm\n> in vim I tend to use \":Ggrep\" and similar commands from the fugitive plugin [1].\n> I don't *think* I'm alone in this.\n\nI can believe there are tons of users of the plugin.  My point still\nstands---such a plugin can export GIT_EDITOR=cat when running \"git\njump\" and there is no need to change \"git jump\".\n"}]}