threads / patch / 5312

patchgitweb: bugfix: commitdiff regression

Subject: [PATCH] gitweb: bugfix: commitdiff regression

## tl;dr

2 messages between Aug 17, 2006 and Aug 17, 2006. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Luben Tuikov· Aug 17, 2006, 22:00 UTC · lore

Fix regression in git_commitdiff() introduced by commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103.

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to gitweb/gitweb.perl +1 −1
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index bb77b55..b97342f 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2414,7 +2414,7 @@ sub git_commitdiff {
 				      $cgi->a({-href => href(action=>"blob", hash=>$from_id, hash_base=>$hash_parent, file_name=>$file)}, $from_id) .
 				      " -> " .
 				      file_type($to_mode) . ":" .
-				      $cgi->a({-href => href(action=>"blob", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id) .
+				      $cgi->a({-href => href(action=>"blob", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id);
 				print "</div>\n";
 				git_diff_print($from_id, "a/$file",  $to_id, "b/$file");
 			}
-- 
1.4.2.g75c01
Jakub Narebski· Aug 17, 2006, 22:11 UTC · re: Luben Tuikov · lore

Re: [PATCH] gitweb: bugfix: commitdiff regression

Luben Tuikov wrote:
Show 7 quoted lines
> Fix regression in git_commitdiff() introduced
> by commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103.
> 
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> ---
>  gitweb/gitweb.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Could you please attach patches inline, and if it is not possible due to whitespace munging, at least attach them as text/plain with 8bit encoding, not base64 encoding?

TIA
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

← back to recent threads