# [PATCH] gitweb: bugfix: commitdiff regression

2 messages from 2006-08-17 to 2006-08-17. Participants: Luben Tuikov, Jakub Narebski.
Thread: https://gitlist.dev/t/5312

## Luben Tuikov, 2006-08-17 22:00

Subject: [PATCH] gitweb: bugfix: commitdiff regression
Message-ID: <20060817220037.22377.qmail@web31812.mail.mud.yahoo.com>
URL: https://gitlist.dev/e/20060817220037.22377.qmail%40web31812.mail.mud.yahoo.com

```
Fix regression in git_commitdiff() introduced
by commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103.

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index bb77b55..b97342f 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2414,7 +2414,7 @@ sub git_commitdiff {
 				      $cgi->a({-href => href(action=>"blob", hash=>$from_id, hash_base=>$hash_parent, file_name=>$file)}, $from_id) .
 				      " -> " .
 				      file_type($to_mode) . ":" .
-				      $cgi->a({-href => href(action=>"blob", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id) .
+				      $cgi->a({-href => href(action=>"blob", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id);
 				print "</div>\n";
 				git_diff_print($from_id, "a/$file",  $to_id, "b/$file");
 			}
-- 
1.4.2.g75c01


```

## Jakub Narebski, 2006-08-17 22:11

Subject: Re: [PATCH] gitweb: bugfix: commitdiff regression
Message-ID: <ec2pgb$3ml$1@sea.gmane.org>
URL: https://gitlist.dev/e/ec2pgb%243ml%241%40sea.gmane.org
In-Reply-To: <20060817220037.22377.qmail@web31812.mail.mud.yahoo.com>

```
Luben Tuikov wrote:

> Fix regression in git_commitdiff() introduced
> by commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103.
> 
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> ---
>  gitweb/gitweb.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Could you please attach patches inline, and if it is not possible due to
whitespace munging, at least attach them as text/plain with 8bit encoding,
not base64 encoding?

TIA

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

```