{"thread":{"id":"5312","subject":"[PATCH] gitweb: bugfix: commitdiff regression","startedAt":"2006-08-17T22:00:37Z","lastAt":"2006-08-17T22:11:22Z","messageCount":2,"participants":["Luben Tuikov","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"25509","messageId":"20060817220037.22377.qmail@web31812.mail.mud.yahoo.com","threadId":"5312","inReplyTo":null,"subject":"[PATCH] gitweb: bugfix: commitdiff regression","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-08-17T22:00:37Z","receivedAt":"2006-08-17T22:00:37Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Fix regression in git_commitdiff() introduced\nby commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103.\n\nSigned-off-by: Luben Tuikov <ltuikov@yahoo.com>\n---\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex bb77b55..b97342f 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2414,7 +2414,7 @@ sub git_commitdiff {\n \t\t\t\t      $cgi->a({-href => href(action=>\"blob\", hash=>$from_id, hash_base=>$hash_parent, file_name=>$file)}, $from_id) .\n \t\t\t\t      \" -> \" .\n \t\t\t\t      file_type($to_mode) . \":\" .\n-\t\t\t\t      $cgi->a({-href => href(action=>\"blob\", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id) .\n+\t\t\t\t      $cgi->a({-href => href(action=>\"blob\", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id);\n \t\t\t\tprint \"</div>\\n\";\n \t\t\t\tgit_diff_print($from_id, \"a/$file\",  $to_id, \"b/$file\");\n \t\t\t}\n-- \n1.4.2.g75c01\n\n"},{"id":"25510","messageId":"ec2pgb$3ml$1@sea.gmane.org","threadId":"5312","inReplyTo":"20060817220037.22377.qmail@web31812.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: bugfix: commitdiff regression","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-08-17T22:11:22Z","receivedAt":"2006-08-17T22:11:22Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Luben Tuikov wrote:\n\n> Fix regression in git_commitdiff() introduced\n> by commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103.\n> \n> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>\n> ---\n>  gitweb/gitweb.perl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n\nCould you please attach patches inline, and if it is not possible due to\nwhitespace munging, at least attach them as text/plain with 8bit encoding,\nnot base64 encoding?\n\nTIA\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"}]}