threads / bug / 53062

Regression in git ls-files, or bug in completion?

Subject: Regression in git ls-files, or bug in completion?

## tl;dr

4 messages between Mar 22, 2020 and Mar 31, 2020.

replies: 3people: 2as markdown or json

Felipe Contreras· Mar 22, 2020, 23:39 UTC · lore

Hi,

I noticed a possible regression caused by commit b9670c1f5e (dir: fix checks on common prefix directory).

What is supposed to be the output of this?

  git init
  mkdir simple-dir
  touch simple-dir/empty
  git -C simple-dir ls-files --other --directory

Before it was "empty", now it is "./".

This causes bash's completion to be botched; "git add simple-dir/" adds "simple-dir/./".

Cheers.

-- 
Felipe Contreras

Felipe Contreras· Mar 28, 2020, 13:25 UTC · re: Felipe Contreras · lore

Re: Regression in git ls-files, or bug in completion?

On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras <felipe.contreras@gmail.com> wrote:

> I noticed a possible regression caused by commit b9670c1f5e (dir: fix
> checks on common prefix directory).

> Before it was "empty", now it is "./".

I guess you don't care about this regression.

-- 
Felipe Contreras

Elijah Newren· Mar 28, 2020, 17:22 UTC · re: Felipe Contreras · lore

Re: Regression in git ls-files, or bug in completion?

On Sat, Mar 28, 2020 at 6:25 AM Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 10 quoted lines

>
> On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>
> > I noticed a possible regression caused by commit b9670c1f5e (dir: fix
> > checks on common prefix directory).
>
> > Before it was "empty", now it is "./".
>
> I guess you don't care about this regression.

Sorry for being slow to get back to you; it wasn't that I didn't care (I marked the message as important to return to) but that I was focused on 2.26 regressions and other fixes I've been promising for months. I'm working on a fix for this 2.25 regression, but note that it's going to depend on this series: https://lore.kernel.org/git/pull.700.v4.git.git.1585258061.gitgitgadget@gmail.com/

Felipe Contreras· Mar 31, 2020, 22:54 UTC · re: Elijah Newren · lore

Re: Regression in git ls-files, or bug in completion?

On Sat, Mar 28, 2020 at 11:22 AM Elijah Newren <newren@gmail.com> wrote:

Show 20 quoted lines

>
> On Sat, Mar 28, 2020 at 6:25 AM Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> >
> > On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras
> > <felipe.contreras@gmail.com> wrote:
> >
> > > I noticed a possible regression caused by commit b9670c1f5e (dir: fix
> > > checks on common prefix directory).
> >
> > > Before it was "empty", now it is "./".
> >
> > I guess you don't care about this regression.
>
> Sorry for being slow to get back to you; it wasn't that I didn't care
> (I marked the message as important to return to) but that I was
> focused on 2.26 regressions and other fixes I've been promising for
> months.  I'm working on a fix for this 2.25 regression, but note that
> it's going to depend on this series:
> https://lore.kernel.org/git/pull.700.v4.git.git.1585258061.gitgitgadget@gmail.com/

I see. Please let me know when you have something ready to test.

-- 
Felipe Contreras