{"thread":{"id":"53062","subject":"Regression in git ls-files, or bug in completion?","startedAt":"2020-03-22T23:40:00Z","lastAt":"2020-03-31T22:54:28Z","messageCount":4,"participants":["Felipe Contreras","Elijah Newren"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"393749","messageId":"CAMP44s2XuXrgBztke50YgnZ1SQh6gvR6cdLz064xDDK3+s2CSA@mail.gmail.com","threadId":"53062","inReplyTo":null,"subject":"Regression in git ls-files, or bug in completion?","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-03-22T23:39:47Z","receivedAt":"2020-03-22T23:40:00Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Hi,\n\nI noticed a possible regression caused by commit b9670c1f5e (dir: fix\nchecks on common prefix directory).\n\nWhat is supposed to be the output of this?\n\n  git init\n  mkdir simple-dir\n  touch simple-dir/empty\n  git -C simple-dir ls-files --other --directory\n\nBefore it was \"empty\", now it is \"./\".\n\nThis causes bash's completion to be botched; \"git add simple-dir/\"\nadds \"simple-dir/./\".\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"394225","messageId":"CAMP44s1oKq3hf+dRyQjc+yOs3xesq5qn5UaJJ_0i-KYrXCeodg@mail.gmail.com","threadId":"53062","inReplyTo":"CAMP44s2XuXrgBztke50YgnZ1SQh6gvR6cdLz064xDDK3+s2CSA@mail.gmail.com","subject":"Re: Regression in git ls-files, or bug in completion?","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-03-28T13:25:34Z","receivedAt":"2020-03-28T13:25:50Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras\n<felipe.contreras@gmail.com> wrote:\n\n> I noticed a possible regression caused by commit b9670c1f5e (dir: fix\n> checks on common prefix directory).\n\n> Before it was \"empty\", now it is \"./\".\n\nI guess you don't care about this regression.\n\n-- \nFelipe Contreras\n"},{"id":"394245","messageId":"CABPp-BG6QQV5aMbrUhB+mCU_fErwLY5uYHzi6DKV5jkPd1p8DA@mail.gmail.com","threadId":"53062","inReplyTo":"CAMP44s1oKq3hf+dRyQjc+yOs3xesq5qn5UaJJ_0i-KYrXCeodg@mail.gmail.com","subject":"Re: Regression in git ls-files, or bug in completion?","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2020-03-28T17:22:47Z","receivedAt":"2020-03-28T17:23:00Z","isPatch":false,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Sat, Mar 28, 2020 at 6:25 AM Felipe Contreras\n<felipe.contreras@gmail.com> wrote:\n>\n> On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras\n> <felipe.contreras@gmail.com> wrote:\n>\n> > I noticed a possible regression caused by commit b9670c1f5e (dir: fix\n> > checks on common prefix directory).\n>\n> > Before it was \"empty\", now it is \"./\".\n>\n> I guess you don't care about this regression.\n\nSorry for being slow to get back to you; it wasn't that I didn't care\n(I marked the message as important to return to) but that I was\nfocused on 2.26 regressions and other fixes I've been promising for\nmonths.  I'm working on a fix for this 2.25 regression, but note that\nit's going to depend on this series:\nhttps://lore.kernel.org/git/pull.700.v4.git.git.1585258061.gitgitgadget@gmail.com/\n"},{"id":"394444","messageId":"CAMP44s2FT07h1rGffP59U_8663Y1SM+dJ4mMaU7k2MjHmeTJFg@mail.gmail.com","threadId":"53062","inReplyTo":"CABPp-BG6QQV5aMbrUhB+mCU_fErwLY5uYHzi6DKV5jkPd1p8DA@mail.gmail.com","subject":"Re: Regression in git ls-files, or bug in completion?","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2020-03-31T22:54:12Z","receivedAt":"2020-03-31T22:54:28Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sat, Mar 28, 2020 at 11:22 AM Elijah Newren <newren@gmail.com> wrote:\n>\n> On Sat, Mar 28, 2020 at 6:25 AM Felipe Contreras\n> <felipe.contreras@gmail.com> wrote:\n> >\n> > On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras\n> > <felipe.contreras@gmail.com> wrote:\n> >\n> > > I noticed a possible regression caused by commit b9670c1f5e (dir: fix\n> > > checks on common prefix directory).\n> >\n> > > Before it was \"empty\", now it is \"./\".\n> >\n> > I guess you don't care about this regression.\n>\n> Sorry for being slow to get back to you; it wasn't that I didn't care\n> (I marked the message as important to return to) but that I was\n> focused on 2.26 regressions and other fixes I've been promising for\n> months.  I'm working on a fix for this 2.25 regression, but note that\n> it's going to depend on this series:\n> https://lore.kernel.org/git/pull.700.v4.git.git.1585258061.gitgitgadget@gmail.com/\n\nI see. Please let me know when you have something ready to test.\n\n-- \nFelipe Contreras\n"}]}