# Regression in git ls-files, or bug in completion? 4 messages from 2020-03-22 to 2020-03-31. Participants: Felipe Contreras, Elijah Newren. Thread: https://gitlist.dev/t/53062 ## Felipe Contreras, 2020-03-22 23:39 Subject: Regression in git ls-files, or bug in completion? Message-ID: URL: https://gitlist.dev/e/CAMP44s2XuXrgBztke50YgnZ1SQh6gvR6cdLz064xDDK3%2Bs2CSA%40mail.gmail.com ``` Hi, I noticed a possible regression caused by commit b9670c1f5e (dir: fix checks on common prefix directory). What is supposed to be the output of this? git init mkdir simple-dir touch simple-dir/empty git -C simple-dir ls-files --other --directory Before it was "empty", now it is "./". This causes bash's completion to be botched; "git add simple-dir/" adds "simple-dir/./". Cheers. -- Felipe Contreras ``` ## Felipe Contreras, 2020-03-28 13:25 Subject: Re: Regression in git ls-files, or bug in completion? Message-ID: URL: https://gitlist.dev/e/CAMP44s1oKq3hf%2BdRyQjc%2ByOs3xesq5qn5UaJJ_0i-KYrXCeodg%40mail.gmail.com In-Reply-To: ``` On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras wrote: > I noticed a possible regression caused by commit b9670c1f5e (dir: fix > checks on common prefix directory). > Before it was "empty", now it is "./". I guess you don't care about this regression. -- Felipe Contreras ``` ## Elijah Newren, 2020-03-28 17:22 Subject: Re: Regression in git ls-files, or bug in completion? Message-ID: URL: https://gitlist.dev/e/CABPp-BG6QQV5aMbrUhB%2BmCU_fErwLY5uYHzi6DKV5jkPd1p8DA%40mail.gmail.com In-Reply-To: ``` On Sat, Mar 28, 2020 at 6:25 AM Felipe Contreras wrote: > > On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras > wrote: > > > I noticed a possible regression caused by commit b9670c1f5e (dir: fix > > checks on common prefix directory). > > > Before it was "empty", now it is "./". > > I guess you don't care about this regression. Sorry for being slow to get back to you; it wasn't that I didn't care (I marked the message as important to return to) but that I was focused on 2.26 regressions and other fixes I've been promising for months. I'm working on a fix for this 2.25 regression, but note that it's going to depend on this series: https://lore.kernel.org/git/pull.700.v4.git.git.1585258061.gitgitgadget@gmail.com/ ``` ## Felipe Contreras, 2020-03-31 22:54 Subject: Re: Regression in git ls-files, or bug in completion? Message-ID: URL: https://gitlist.dev/e/CAMP44s2FT07h1rGffP59U_8663Y1SM%2BdJ4mMaU7k2MjHmeTJFg%40mail.gmail.com In-Reply-To: ``` On Sat, Mar 28, 2020 at 11:22 AM Elijah Newren wrote: > > On Sat, Mar 28, 2020 at 6:25 AM Felipe Contreras > wrote: > > > > On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras > > wrote: > > > > > I noticed a possible regression caused by commit b9670c1f5e (dir: fix > > > checks on common prefix directory). > > > > > Before it was "empty", now it is "./". > > > > I guess you don't care about this regression. > > Sorry for being slow to get back to you; it wasn't that I didn't care > (I marked the message as important to return to) but that I was > focused on 2.26 regressions and other fixes I've been promising for > months. I'm working on a fix for this 2.25 regression, but note that > it's going to depend on this series: > https://lore.kernel.org/git/pull.700.v4.git.git.1585258061.gitgitgadget@gmail.com/ I see. Please let me know when you have something ready to test. -- Felipe Contreras ```