threads / discuss / 53022

[GSoC] Microproject for git

Subject: [GSoC] Microproject for git

## tl;dr

4 messages between Mar 18, 2020 and Mar 19, 2020.

replies: 3people: 4as markdown or json

Harshit Jain· Mar 18, 2020, 18:59 UTC · lore

Hi, I am Harshit Jain, a senior undergraduate student pursuing bachelors at IIT Delhi. In the coming summers, I am really looking forward to contribute to git as a part of the GSoC program. And for the same, I am working on the "Use test_path_is_* functions in test scripts" microproject. As a part of the same, I found a few test scripts where the 'test -f' can potentially be replaced by 'test_path_is_file' function. I changed one test script and it works fine. So, should I just commit this change now (the change looks very trivial to me) and if not, how to proceed from here?

Kind regards, Harshit Jain Senior Undergraduate, IIT Delhi

Shourya Shukla· Mar 18, 2020, 19:27 UTC · re: Harshit Jain · lore

Re:[GSoC] Microproject for git

Hello Harshit,

> I found a few test scripts where the 'test -f' can potentially be replaced by 'test_path_is_file'
> function.

That's nice!

> I changed one test script and it works fine. So, should I
> just commit this change now (the change looks very trivial to me) and
> if not, how to proceed from here?

Make sure to execute a 'make' in the working directory so that your changes _actually_ have some effect. Running a changed test without 'make' is basically running the old test all over again.

You could also maybe do some code modernizations. What I did as my microproject might be of some help:

https://lore.kernel.org/git/20200118083326.9643-1-shouryashukla.oo@gmail.com/

Also, make sure the commit message is descriptive and does not contain any extra whitespaces. I think you must know by now that we submit patches here via the mailing list and not pull requests.

Regards, Shourya Shukla

Hariom verma· Mar 18, 2020, 20:05 UTC · re: Shourya Shukla · lore

Re: [GSoC] Microproject for git

Hi Harshit,

On Thu, Mar 19, 2020 at 12:58 AM Shourya Shukla

> I think you must know by now that we submit patches here
> via the mailing list and not pull requests.

I addition to what Shourya said, you can also make it easier on yourself by using GitGitGadget, which takes out the pain of sending patches in the required format via email, see https://gitgitgadget.github.io/ for details.

Regards, Hariom

Kaartic Sivaraam· Mar 19, 2020, 08:03 UTC · re: Hariom verma · lore

Re: [GSoC] Microproject for git

Hi Harshit,

On 19-03-2020 01:35, Hariom verma wrote:

Show 11 quoted lines

> Hi Harshit,
> 
> On Thu, Mar 19, 2020 at 12:58 AM Shourya Shukla
>> I think you must know by now that we submit patches here
>> via the mailing list and not pull requests.
> 
> I addition to what Shourya said, you can also make it easier on
> yourself by using GitGitGadget, which takes out the pain of sending
> patches in the required format via email, see
> https://gitgitgadget.github.io/ for details.
>

There's also a MyFirstContribution[1] document which could help you. Particularly, there's a section[2] which contains step-by-step information about how to send patches using GitGitGadget.

Good luck with your contribution :)

[1]: https://git-scm.com/docs/MyFirstContribution [2]: https://git-scm.com/docs/MyFirstContribution#howto-ggg

-- 
Sivaraam