git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re:[GSoC] Microproject for git

From
Shourya Shukla <shouryashukla.oo@gmail.com>
Date
Mar 18, 2020, 19:27 UTC
Message-ID
<20200318192719.1127-1-shouryashukla.oo@gmail.com>
In-Reply-To
<CACuU+s9BsWVCMXpp6KgJ-NaDuadcegZ2kVSMmuAYO9YquTK8LA@mail.gmail.com>
Hello Harshit,
> I found a few test scripts where the 'test -f' can potentially be replaced by 'test_path_is_file'
> function.
That's nice!
> I changed one test script and it works fine. So, should I
> just commit this change now (the change looks very trivial to me) and
> if not, how to proceed from here?

Make sure to execute a 'make' in the working directory so that your changes _actually_ have some effect. Running a changed test without 'make' is basically running the old test all over again.

You could also maybe do some code modernizations. What I did as my microproject might be of some help:

https://lore.kernel.org/git/20200118083326.9643-1-shouryashukla.oo@gmail.com/

Also, make sure the commit message is descriptive and does not contain any extra whitespaces. I think you must know by now that we submit patches here via the mailing list and not pull requests.

Regards, Shourya Shukla

Previous: Harshit JainNext: Hariom verma
Message 2 of 4 in “[GSoC] Microproject for git”
  1. Harshit JainMar 18, 2020
  2. Shourya ShuklaMar 18, 2020
  3. Hariom vermaMar 18, 2020
  4. Kaartic SivaraamMar 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.