threads / patch / 5220

patchRe: [PATCH] make git compile on old version of engarde linux

Subject: Re: [PATCH] make git compile on old version of engarde linux

## tl;dr

2 messages between Aug 12, 2006 and Aug 12, 2006. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Michael S. Tsirkin· Aug 12, 2006, 22:45 UTC · lore

Quoting r. Junio C Hamano <junkio@cox.net>:

Show 12 quoted lines

> > This looks familiar; did the build error out when compiling
> > convert-objects.c by any chance? I suspect you have the same problem
> > that I encountered.  My fix was posted in "[PATCH 6/10] Fix header breakage
> > with _XOPEN_SOURCE."
> >
> > I have included my earlier mail message inline below, in case you wish
> > to confirm the that it fixes things for you too.
> 
> Alternatively Ramsay's _XOPEN_SOURCE patch is part of "next", so
> if it fixes the problem for you that would confirm the patch is
> a good one to have.
>

BTW, would it make sense fr this patch to be cherry-picked into 1.4.8?
I guess the reason that LNK macros are under GNU_SOURCE is the following
text from stat(2):
 
       The S_ISLNK and S_ISSOCK macros
       are not in POSIX.1-1996, but both will be in the next  POSIX  standard;
       the former is from SVID 4v2, the latter from SUSv2.

-- 
MST

Junio C Hamano· Aug 12, 2006, 23:09 UTC · re: Michael S. Tsirkin · lore

"Michael S. Tsirkin" <mst@mellanox.co.il> writes:

Show 11 quoted lines

>> Alternatively Ramsay's _XOPEN_SOURCE patch is part of "next", so
>> if it fixes the problem for you that would confirm the patch is
>> a good one to have.
>
> BTW, would it make sense fr this patch to be cherry-picked into 1.4.8?
> I guess the reason that LNK macros are under GNU_SOURCE is the following
> text from stat(2):
>  
>        The S_ISLNK and S_ISSOCK macros
>        are not in POSIX.1-1996, but both will be in the next  POSIX  standard;
>        the former is from SVID 4v2, the latter from SUSv2.

I originally scheduled it for immediately after 1.4.2 but I would say why not. It makes sense and does not seem to break for people (otherwise I would have heard screams, hopefully).