{"thread":{"id":"5220","subject":"Re: [PATCH] make git compile on old version of engarde linux","startedAt":"2006-08-12T22:45:20Z","lastAt":"2006-08-12T23:09:11Z","messageCount":2,"participants":["Michael S. Tsirkin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"25169","messageId":"20060812224520.GB13704@mellanox.co.il","threadId":"5220","inReplyTo":"7vac6etz5n.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] make git compile on old version of engarde linux","fromName":"Michael S. Tsirkin","fromEmail":"mst@mellanox.co.il","sentAt":"2006-08-12T22:45:20Z","receivedAt":"2006-08-12T22:45:20Z","isPatch":true,"sender":{"key":"mst@kernel.org","avatar":null},"body":"Quoting r. Junio C Hamano <junkio@cox.net>:\n> > This looks familiar; did the build error out when compiling\n> > convert-objects.c by any chance? I suspect you have the same problem\n> > that I encountered.  My fix was posted in \"[PATCH 6/10] Fix header breakage\n> > with _XOPEN_SOURCE.\"\n> >\n> > I have included my earlier mail message inline below, in case you wish\n> > to confirm the that it fixes things for you too.\n> \n> Alternatively Ramsay's _XOPEN_SOURCE patch is part of \"next\", so\n> if it fixes the problem for you that would confirm the patch is\n> a good one to have.\n> \n\nBTW, would it make sense fr this patch to be cherry-picked into 1.4.8?\nI guess the reason that LNK macros are under GNU_SOURCE is the following\ntext from stat(2):\n \n       The S_ISLNK and S_ISSOCK macros\n       are not in POSIX.1-1996, but both will be in the next  POSIX  standard;\n       the former is from SVID 4v2, the latter from SUSv2.\n\n-- \nMST\n"},{"id":"25172","messageId":"7vr6zlo8ko.fsf@assigned-by-dhcp.cox.net","threadId":"5220","inReplyTo":"20060812224520.GB13704@mellanox.co.il","subject":"Re: [PATCH] make git compile on old version of engarde linux","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-12T23:09:11Z","receivedAt":"2006-08-12T23:09:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Michael S. Tsirkin\" <mst@mellanox.co.il> writes:\n\n>> Alternatively Ramsay's _XOPEN_SOURCE patch is part of \"next\", so\n>> if it fixes the problem for you that would confirm the patch is\n>> a good one to have.\n>\n> BTW, would it make sense fr this patch to be cherry-picked into 1.4.8?\n> I guess the reason that LNK macros are under GNU_SOURCE is the following\n> text from stat(2):\n>  \n>        The S_ISLNK and S_ISSOCK macros\n>        are not in POSIX.1-1996, but both will be in the next  POSIX  standard;\n>        the former is from SVID 4v2, the latter from SUSv2.\n\nI originally scheduled it for immediately after 1.4.2 but I\nwould say why not.  It makes sense and does not seem to break\nfor people (otherwise I would have heard screams, hopefully).\n"}]}