# Re: [PATCH] make git compile on old version of engarde linux

2 messages from 2006-08-12 to 2006-08-12. Participants: Michael S. Tsirkin, Junio C Hamano.
Thread: https://gitlist.dev/t/5220

## Michael S. Tsirkin, 2006-08-12 22:45

Subject: Re: [PATCH] make git compile on old version of engarde linux
Message-ID: <20060812224520.GB13704@mellanox.co.il>
URL: https://gitlist.dev/e/20060812224520.GB13704%40mellanox.co.il
In-Reply-To: <7vac6etz5n.fsf@assigned-by-dhcp.cox.net>

```
Quoting r. Junio C Hamano <junkio@cox.net>:
> > This looks familiar; did the build error out when compiling
> > convert-objects.c by any chance? I suspect you have the same problem
> > that I encountered.  My fix was posted in "[PATCH 6/10] Fix header breakage
> > with _XOPEN_SOURCE."
> >
> > I have included my earlier mail message inline below, in case you wish
> > to confirm the that it fixes things for you too.
> 
> Alternatively Ramsay's _XOPEN_SOURCE patch is part of "next", so
> if it fixes the problem for you that would confirm the patch is
> a good one to have.
> 

BTW, would it make sense fr this patch to be cherry-picked into 1.4.8?
I guess the reason that LNK macros are under GNU_SOURCE is the following
text from stat(2):
 
       The S_ISLNK and S_ISSOCK macros
       are not in POSIX.1-1996, but both will be in the next  POSIX  standard;
       the former is from SVID 4v2, the latter from SUSv2.

-- 
MST

```

## Junio C Hamano, 2006-08-12 23:09

Subject: Re: [PATCH] make git compile on old version of engarde linux
Message-ID: <7vr6zlo8ko.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vr6zlo8ko.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20060812224520.GB13704@mellanox.co.il>

```
"Michael S. Tsirkin" <mst@mellanox.co.il> writes:

>> Alternatively Ramsay's _XOPEN_SOURCE patch is part of "next", so
>> if it fixes the problem for you that would confirm the patch is
>> a good one to have.
>
> BTW, would it make sense fr this patch to be cherry-picked into 1.4.8?
> I guess the reason that LNK macros are under GNU_SOURCE is the following
> text from stat(2):
>  
>        The S_ISLNK and S_ISSOCK macros
>        are not in POSIX.1-1996, but both will be in the next  POSIX  standard;
>        the former is from SVID 4v2, the latter from SUSv2.

I originally scheduled it for immediately after 1.4.2 but I
would say why not.  It makes sense and does not seem to break
for people (otherwise I would have heard screams, hopefully).

```