threads / discuss / 51865

git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char

Subject: git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char

## tl;dr

2 messages between Sep 17, 2019 and Sep 17, 2019.

replies: 1people: 1as markdown or json

Birger Skogeng Pedersen· Sep 17, 2019, 10:48 UTC · lore

Hi,

I ran into som issues when compiling git-gui on Windows. Turns out that the "sharedir" variable gets an incorrect value when "gitexecdir" contains a space.

For instance when gitexecdir is set to "/c/Program Files/Git/mingw64/libexec", sharedir becomes "/c/ Files/Git/mingw64/share".

Perhaps it is me doing something wrong when setting the gitexecdir env variable? I use export gitexecdir=/c/Program\ Files/Git/mingw64/libexec

If that's a way to do it, should the Makefile be modified to derive sharedir another way? Perhaps with a check if we're on a Windows system.

What do you think?

Birger

Birger Skogeng Pedersen· Sep 17, 2019, 11:24 UTC · re: Birger Skogeng Pedersen · lore

Re: git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char

Just saw this[0] issue discussed about GNU Make. It seems Make don't play with path with spaces (at all). I guess my best solution is just to make a symbolic link so there's a path without spaces. I guess this issue can be ignored.

[0] http://savannah.gnu.org/bugs/?712

Best regards, Birger