git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char
- From
Birger Skogeng Pedersen <birger.sp@gmail.com>
- Date
- Sep 17, 2019, 10:48 UTC
- Message-ID
- <CAGr--=+L6tff-5oSX9oAF6AnvPwv8GDxb8vfyhRBnSS+JU7AAw@mail.gmail.com>
Hi,
I ran into som issues when compiling git-gui on Windows. Turns out that the "sharedir" variable gets an incorrect value when "gitexecdir" contains a space.
For instance when gitexecdir is set to "/c/Program Files/Git/mingw64/libexec", sharedir becomes "/c/ Files/Git/mingw64/share".
Perhaps it is me doing something wrong when setting the gitexecdir env variable? I use export gitexecdir=/c/Program\ Files/Git/mingw64/libexec
If that's a way to do it, should the Makefile be modified to derive sharedir another way? Perhaps with a check if we're on a Windows system.
What do you think?
Birger