{"thread":{"id":"51865","subject":"git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char","startedAt":"2019-09-17T10:51:07Z","lastAt":"2019-09-17T11:27:38Z","messageCount":2,"participants":["Birger Skogeng Pedersen"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"382481","messageId":"CAGr--=+L6tff-5oSX9oAF6AnvPwv8GDxb8vfyhRBnSS+JU7AAw@mail.gmail.com","threadId":"51865","inReplyTo":null,"subject":"git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char","fromName":"Birger Skogeng Pedersen","fromEmail":"birger.sp@gmail.com","sentAt":"2019-09-17T10:48:23Z","receivedAt":"2019-09-17T10:51:07Z","isPatch":false,"sender":{"key":"birger.sp@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5260237?v=4"},"body":"Hi,\n\n\nI ran into som issues when compiling git-gui on Windows. Turns out\nthat the \"sharedir\" variable gets an incorrect value when \"gitexecdir\"\ncontains a space.\n\nFor instance when\ngitexecdir is set to \"/c/Program Files/Git/mingw64/libexec\",\nsharedir becomes \"/c/ Files/Git/mingw64/share\".\n\nPerhaps it is me doing something wrong when setting the gitexecdir env\nvariable? I use\nexport gitexecdir=/c/Program\\ Files/Git/mingw64/libexec\n\nIf that's a way to do it, should the Makefile be modified to derive\nsharedir another way? Perhaps with a check if we're on a Windows\nsystem.\n\nWhat do you think?\n\n\nBirger\n"},{"id":"382483","messageId":"CAGr--=JMEuCRZZaiE0Djw6igSm4DgVrgxKPVEEZuiaH6yfY1wQ@mail.gmail.com","threadId":"51865","inReplyTo":"CAGr--=+L6tff-5oSX9oAF6AnvPwv8GDxb8vfyhRBnSS+JU7AAw@mail.gmail.com","subject":"Re: git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char","fromName":"Birger Skogeng Pedersen","fromEmail":"birger.sp@gmail.com","sentAt":"2019-09-17T11:24:53Z","receivedAt":"2019-09-17T11:27:38Z","isPatch":false,"sender":{"key":"birger.sp@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5260237?v=4"},"body":"Just saw this[0] issue discussed about GNU Make. It seems Make don't\nplay with path with spaces (at all). I guess my best solution is just\nto make a symbolic link so there's a path without spaces.\nI guess this issue can be ignored.\n\n[0] http://savannah.gnu.org/bugs/?712\n\nBest regards,\nBirger\n"}]}