threads / patch / 51760

patchcommit-graph: emit trace2 cmd_mode for each sub-command

Subject: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command

## tl;dr

5 messages between Aug 27, 2019 and Oct 2, 2019. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Garima Singh via GitGitGadget· Aug 27, 2019, 16:56 UTC · lore

Emit trace2_cmd_mode() messages for each commit-graph sub-command.

The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the various modes within them. Distinguishing between read, write and verify is a great start.

Signed-off-by: Garima Singh garima.singh@microsoft.com
[garima.singh@microsoft.com]

CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com, 
avarab@gmail.com

Garima Singh (1):
  commit-graph: emit trace2 cmd_mode for each sub-command

 builtin/commit-graph.c | 6 ++++++
 1 file changed, 6 insertions(+)

base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-323/garimasi514/coreGit-commit-graph-trace2-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/323

-- 
gitgitgadget

Garima Singh via GitGitGadget· Aug 27, 2019, 16:56 UTC · re: Garima Singh via GitGitGadget · lore

[PATCH 1/1] commit-graph: emit trace2 cmd_mode for each sub-command

From: Garima Singh <garima.singh@microsoft.com>

Emit trace2_cmd_mode() messages for each commit-graph sub-command.

Signed-off-by: Garima Singh <garima.singh@microsoft.com>
---
 builtin/commit-graph.c | 6 ++++++
 1 file changed, 6 insertions(+)

Show changes to builtin/commit-graph.c +6 −0

diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index 57863619b7..ef68b26744 100644
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -58,6 +58,8 @@ static int graph_verify(int argc, const char **argv)
 		OPT_END(),
 	};
 
+	trace2_cmd_mode("verify");
+
 	argc = parse_options(argc, argv, NULL,
 			     builtin_commit_graph_verify_options,
 			     builtin_commit_graph_verify_usage, 0);
@@ -102,6 +104,8 @@ static int graph_read(int argc, const char **argv)
 		OPT_END(),
 	};
 
+	trace2_cmd_mode("read");
+
 	argc = parse_options(argc, argv, NULL,
 			     builtin_commit_graph_read_options,
 			     builtin_commit_graph_read_usage, 0);
@@ -183,6 +187,8 @@ static int graph_write(int argc, const char **argv)
 	split_opts.max_commits = 0;
 	split_opts.expire_time = 0;
 
+	trace2_cmd_mode("write");
+
 	argc = parse_options(argc, argv, NULL,
 			     builtin_commit_graph_write_options,
 			     builtin_commit_graph_write_usage, 0);

-- 
gitgitgadget

Garima Singh· Sep 10, 2019, 13:54 UTC · re: Garima Singh via GitGitGadget · lore

Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command

Ping :) Any thoughts on this?

On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote:

Show 25 quoted lines

> Emit trace2_cmd_mode() messages for each commit-graph sub-command.
> 
> The commit graph commands were in flux when trace2 was making it's way to
> git. Now that we have enough sub-commands in commit-graph, we can label the
> various modes within them. Distinguishing between read, write and verify is
> a great start.
> 
> Signed-off-by: Garima Singh garima.singh@microsoft.com
> [garima.singh@microsoft.com]
> 
> CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com,
> avarab@gmail.com
> 
> Garima Singh (1):
>    commit-graph: emit trace2 cmd_mode for each sub-command
> 
>   builtin/commit-graph.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> 
> base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-323/garimasi514/coreGit-commit-graph-trace2-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/323
>

Jeff Hostetler· Sep 11, 2019, 18:17 UTC · re: Garima Singh · lore

Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command

On 9/10/2019 9:54 AM, Garima Singh wrote:

Show 33 quoted lines

> Ping :) Any thoughts on this?
> 
> On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote:
>> Emit trace2_cmd_mode() messages for each commit-graph sub-command.
>>
>> The commit graph commands were in flux when trace2 was making it's way to
>> git. Now that we have enough sub-commands in commit-graph, we can 
>> label the
>> various modes within them. Distinguishing between read, write and 
>> verify is
>> a great start.
>>
>> Signed-off-by: Garima Singh garima.singh@microsoft.com
>> [garima.singh@microsoft.com]
>>
>> CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com,
>> avarab@gmail.com
>>
>> Garima Singh (1):
>>    commit-graph: emit trace2 cmd_mode for each sub-command
>>
>>   builtin/commit-graph.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>>
>> base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
>> Published-As: 
>> https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1 
>>
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git 
>> pr-323/garimasi514/coreGit-commit-graph-trace2-v1
>> Pull-Request: https://github.com/gitgitgadget/git/pull/323
>>

Looks good to me.  Thanks!

Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>

Johannes Schindelin· Oct 2, 2019, 08:02 UTC · re: Jeff Hostetler · lore

Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command

Hi,

On Wed, 11 Sep 2019, Jeff Hostetler wrote:

Show 36 quoted lines

> On 9/10/2019 9:54 AM, Garima Singh wrote:
> > Ping :) Any thoughts on this?
> >
> > On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote:
> > > Emit trace2_cmd_mode() messages for each commit-graph sub-command.
> > >
> > > The commit graph commands were in flux when trace2 was making it's way to
> > > git. Now that we have enough sub-commands in commit-graph, we can label
> > > the
> > > various modes within them. Distinguishing between read, write and verify
> > > is
> > > a great start.
> > >
> > > Signed-off-by: Garima Singh garima.singh@microsoft.com
> > > [garima.singh@microsoft.com]
> > >
> > > CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com,
> > > avarab@gmail.com
> > >
> > > Garima Singh (1):
> > >    commit-graph: emit trace2 cmd_mode for each sub-command
> > >
> > >   builtin/commit-graph.c | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > >
> > >
> > > base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
> > > Published-As:
> > > https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1
> > >
> > > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git
> > > pr-323/garimasi514/coreGit-commit-graph-trace2-v1
> > > Pull-Request: https://github.com/gitgitgadget/git/pull/323
> > >
>
> Looks good to me.  Thanks!

This was not yet picked up into `pu`, correct? Or did I miss anything?

Ciao, Dscho

>
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>
>