{"thread":{"id":"51760","subject":"[PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command","startedAt":"2019-08-27T16:56:38Z","lastAt":"2019-10-02T08:03:16Z","messageCount":5,"participants":["Garima Singh via GitGitGadget","Garima Singh","Jeff Hostetler","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"381372","messageId":"pull.323.git.gitgitgadget@gmail.com","threadId":"51760","inReplyTo":null,"subject":"[PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command","fromName":"Garima Singh via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-08-27T16:56:33Z","receivedAt":"2019-08-27T16:56:38Z","isPatch":true,"sender":{"key":"garimasigit@gmail.com","avatar":null},"body":"Emit trace2_cmd_mode() messages for each commit-graph sub-command.\n\nThe commit graph commands were in flux when trace2 was making it's way to\ngit. Now that we have enough sub-commands in commit-graph, we can label the\nvarious modes within them. Distinguishing between read, write and verify is\na great start.\n\nSigned-off-by: Garima Singh garima.singh@microsoft.com\n[garima.singh@microsoft.com]\n\nCC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com, \navarab@gmail.com\n\nGarima Singh (1):\n commit-graph: emit trace2 cmd_mode for each sub-command\n\n builtin/commit-graph.c | 6 ++++++\n 1 file changed, 6 insertions(+)\n\n\nbase-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-323/garimasi514/coreGit-commit-graph-trace2-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/323\n-- \ngitgitgadget\n"},{"id":"381373","messageId":"80496fdcfc42cd7ea883ea1a7200ab3611cbbca5.1566924992.git.gitgitgadget@gmail.com","threadId":"51760","inReplyTo":"pull.323.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] commit-graph: emit trace2 cmd_mode for each sub-command","fromName":"Garima Singh via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-08-27T16:56:34Z","receivedAt":"2019-08-27T16:56:39Z","isPatch":true,"sender":{"key":"garimasigit@gmail.com","avatar":null},"body":"From: Garima Singh \n\nEmit trace2_cmd_mode() messages for each commit-graph\nsub-command.\n\nThe commit graph commands were in flux when trace2 was\nmaking it's way to git. Now that we have enough sub-commands\nin commit-graph, we can label the various modes within them.\nDistinguishing between read, write and verify is a great\nstart.\n\nSigned-off-by: Garima Singh \n---\n builtin/commit-graph.c | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/builtin/commit-graph.c b/builtin/commit-graph.c\nindex 57863619b7..ef68b26744 100644\n--- a/builtin/commit-graph.c\n+++ b/builtin/commit-graph.c\n@@ -58,6 +58,8 @@ static int graph_verify(int argc, const char **argv)\n \t\tOPT_END(),\n \t};\n \n+\ttrace2_cmd_mode(\"verify\");\n+\n \targc = parse_options(argc, argv, NULL,\n \t\t\t builtin_commit_graph_verify_options,\n \t\t\t builtin_commit_graph_verify_usage, 0);\n@@ -102,6 +104,8 @@ static int graph_read(int argc, const char **argv)\n \t\tOPT_END(),\n \t};\n \n+\ttrace2_cmd_mode(\"read\");\n+\n \targc = parse_options(argc, argv, NULL,\n \t\t\t builtin_commit_graph_read_options,\n \t\t\t builtin_commit_graph_read_usage, 0);\n@@ -183,6 +187,8 @@ static int graph_write(int argc, const char **argv)\n \tsplit_opts.max_commits = 0;\n \tsplit_opts.expire_time = 0;\n \n+\ttrace2_cmd_mode(\"write\");\n+\n \targc = parse_options(argc, argv, NULL,\n \t\t\t builtin_commit_graph_write_options,\n \t\t\t builtin_commit_graph_write_usage, 0);\n-- \ngitgitgadget\n"},{"id":"382129","messageId":"6d1e51c3-64a4-0075-5c9c-3302c5d07c50@gmail.com","threadId":"51760","inReplyTo":"pull.323.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command","fromName":"Garima Singh","fromEmail":"garimasigit@gmail.com","sentAt":"2019-09-10T13:54:29Z","receivedAt":"2019-09-10T13:54:30Z","isPatch":true,"sender":{"key":"garimasigit@gmail.com","avatar":null},"body":"Ping :) Any thoughts on this?\n\nOn 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote:\n> Emit trace2_cmd_mode() messages for each commit-graph sub-command.\n> \n> The commit graph commands were in flux when trace2 was making it's way to\n> git. Now that we have enough sub-commands in commit-graph, we can label the\n> various modes within them. Distinguishing between read, write and verify is\n> a great start.\n> \n> Signed-off-by: Garima Singh garima.singh@microsoft.com\n> [garima.singh@microsoft.com]\n> \n> CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com,\n> avarab@gmail.com\n> \n> Garima Singh (1):\n> commit-graph: emit trace2 cmd_mode for each sub-command\n> \n> builtin/commit-graph.c | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> \n> base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-323/garimasi514/coreGit-commit-graph-trace2-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/323\n> \n"},{"id":"382174","messageId":"da9a7ce5-736c-9d85-d655-cb19172063f8@jeffhostetler.com","threadId":"51760","inReplyTo":"6d1e51c3-64a4-0075-5c9c-3302c5d07c50@gmail.com","subject":"Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2019-09-11T18:17:42Z","receivedAt":"2019-09-11T18:17:45Z","isPatch":true,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 9/10/2019 9:54 AM, Garima Singh wrote:\n> Ping :) Any thoughts on this?\n> \n> On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote:\n>> Emit trace2_cmd_mode() messages for each commit-graph sub-command.\n>>\n>> The commit graph commands were in flux when trace2 was making it's way to\n>> git. Now that we have enough sub-commands in commit-graph, we can \n>> label the\n>> various modes within them. Distinguishing between read, write and \n>> verify is\n>> a great start.\n>>\n>> Signed-off-by: Garima Singh garima.singh@microsoft.com\n>> [garima.singh@microsoft.com]\n>>\n>> CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com,\n>> avarab@gmail.com\n>>\n>> Garima Singh (1):\n>>    commit-graph: emit trace2 cmd_mode for each sub-command\n>>\n>>   builtin/commit-graph.c | 6 ++++++\n>>   1 file changed, 6 insertions(+)\n>>\n>>\n>> base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26\n>> Published-As: \n>> https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1 \n>>\n>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git \n>> pr-323/garimasi514/coreGit-commit-graph-trace2-v1\n>> Pull-Request: https://github.com/gitgitgadget/git/pull/323\n>>\n\nLooks good to me. Thanks!\n\nSigned-off-by: Jeff Hostetler \n"},{"id":"383259","messageId":"nycvar.QRO.7.76.6.1910021001400.46@tvgsbejvaqbjf.bet","threadId":"51760","inReplyTo":"da9a7ce5-736c-9d85-d655-cb19172063f8@jeffhostetler.com","subject":"Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-10-02T08:02:51Z","receivedAt":"2019-10-02T08:03:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 11 Sep 2019, Jeff Hostetler wrote:\n\n> On 9/10/2019 9:54 AM, Garima Singh wrote:\n> > Ping :) Any thoughts on this?\n> >\n> > On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote:\n> > > Emit trace2_cmd_mode() messages for each commit-graph sub-command.\n> > >\n> > > The commit graph commands were in flux when trace2 was making it's way to\n> > > git. Now that we have enough sub-commands in commit-graph, we can label\n> > > the\n> > > various modes within them. Distinguishing between read, write and verify\n> > > is\n> > > a great start.\n> > >\n> > > Signed-off-by: Garima Singh garima.singh@microsoft.com\n> > > [garima.singh@microsoft.com]\n> > >\n> > > CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com,\n> > > avarab@gmail.com\n> > >\n> > > Garima Singh (1):\n> > >    commit-graph: emit trace2 cmd_mode for each sub-command\n> > >\n> > >   builtin/commit-graph.c | 6 ++++++\n> > >   1 file changed, 6 insertions(+)\n> > >\n> > >\n> > > base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26\n> > > Published-As:\n> > > https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1\n> > >\n> > > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git\n> > > pr-323/garimasi514/coreGit-commit-graph-trace2-v1\n> > > Pull-Request: https://github.com/gitgitgadget/git/pull/323\n> > >\n>\n> Looks good to me. Thanks!\n\nThis was not yet picked up into `pu`, correct? Or did I miss anything?\n\nCiao,\nDscho\n\n>\n> Signed-off-by: Jeff Hostetler \n>\n>\n"}]}