# [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command 5 messages from 2019-08-27 to 2019-10-02. Participants: Garima Singh via GitGitGadget, Garima Singh, Jeff Hostetler, Johannes Schindelin. Thread: https://gitlist.dev/t/51760 ## Garima Singh via GitGitGadget, 2019-08-27 16:56 Subject: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command Message-ID: URL: https://gitlist.dev/e/pull.323.git.gitgitgadget%40gmail.com ``` Emit trace2_cmd_mode() messages for each commit-graph sub-command. The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the various modes within them. Distinguishing between read, write and verify is a great start. Signed-off-by: Garima Singh garima.singh@microsoft.com [garima.singh@microsoft.com] CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com, avarab@gmail.com Garima Singh (1): commit-graph: emit trace2 cmd_mode for each sub-command builtin/commit-graph.c | 6 ++++++ 1 file changed, 6 insertions(+) base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-323/garimasi514/coreGit-commit-graph-trace2-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/323 -- gitgitgadget ``` ## Garima Singh via GitGitGadget, 2019-08-27 16:56 Subject: [PATCH 1/1] commit-graph: emit trace2 cmd_mode for each sub-command Message-ID: <80496fdcfc42cd7ea883ea1a7200ab3611cbbca5.1566924992.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/80496fdcfc42cd7ea883ea1a7200ab3611cbbca5.1566924992.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Garima Singh Emit trace2_cmd_mode() messages for each commit-graph sub-command. The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the various modes within them. Distinguishing between read, write and verify is a great start. Signed-off-by: Garima Singh --- builtin/commit-graph.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c index 57863619b7..ef68b26744 100644 --- a/builtin/commit-graph.c +++ b/builtin/commit-graph.c @@ -58,6 +58,8 @@ static int graph_verify(int argc, const char **argv) OPT_END(), }; + trace2_cmd_mode("verify"); + argc = parse_options(argc, argv, NULL, builtin_commit_graph_verify_options, builtin_commit_graph_verify_usage, 0); @@ -102,6 +104,8 @@ static int graph_read(int argc, const char **argv) OPT_END(), }; + trace2_cmd_mode("read"); + argc = parse_options(argc, argv, NULL, builtin_commit_graph_read_options, builtin_commit_graph_read_usage, 0); @@ -183,6 +187,8 @@ static int graph_write(int argc, const char **argv) split_opts.max_commits = 0; split_opts.expire_time = 0; + trace2_cmd_mode("write"); + argc = parse_options(argc, argv, NULL, builtin_commit_graph_write_options, builtin_commit_graph_write_usage, 0); -- gitgitgadget ``` ## Garima Singh, 2019-09-10 13:54 Subject: Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command Message-ID: <6d1e51c3-64a4-0075-5c9c-3302c5d07c50@gmail.com> URL: https://gitlist.dev/e/6d1e51c3-64a4-0075-5c9c-3302c5d07c50%40gmail.com In-Reply-To: ``` Ping :) Any thoughts on this? On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote: > Emit trace2_cmd_mode() messages for each commit-graph sub-command. > > The commit graph commands were in flux when trace2 was making it's way to > git. Now that we have enough sub-commands in commit-graph, we can label the > various modes within them. Distinguishing between read, write and verify is > a great start. > > Signed-off-by: Garima Singh garima.singh@microsoft.com > [garima.singh@microsoft.com] > > CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com, > avarab@gmail.com > > Garima Singh (1): > commit-graph: emit trace2 cmd_mode for each sub-command > > builtin/commit-graph.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > > base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26 > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-323/garimasi514/coreGit-commit-graph-trace2-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/323 > ``` ## Jeff Hostetler, 2019-09-11 18:17 Subject: Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command Message-ID: URL: https://gitlist.dev/e/da9a7ce5-736c-9d85-d655-cb19172063f8%40jeffhostetler.com In-Reply-To: <6d1e51c3-64a4-0075-5c9c-3302c5d07c50@gmail.com> ``` On 9/10/2019 9:54 AM, Garima Singh wrote: > Ping :) Any thoughts on this? > > On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote: >> Emit trace2_cmd_mode() messages for each commit-graph sub-command. >> >> The commit graph commands were in flux when trace2 was making it's way to >> git. Now that we have enough sub-commands in commit-graph, we can >> label the >> various modes within them. Distinguishing between read, write and >> verify is >> a great start. >> >> Signed-off-by: Garima Singh garima.singh@microsoft.com >> [garima.singh@microsoft.com] >> >> CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com, >> avarab@gmail.com >> >> Garima Singh (1): >>    commit-graph: emit trace2 cmd_mode for each sub-command >> >>   builtin/commit-graph.c | 6 ++++++ >>   1 file changed, 6 insertions(+) >> >> >> base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26 >> Published-As: >> https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1 >> >> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git >> pr-323/garimasi514/coreGit-commit-graph-trace2-v1 >> Pull-Request: https://github.com/gitgitgadget/git/pull/323 >> Looks good to me. Thanks! Signed-off-by: Jeff Hostetler ``` ## Johannes Schindelin, 2019-10-02 08:02 Subject: Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.1910021001400.46%40tvgsbejvaqbjf.bet In-Reply-To: ``` Hi, On Wed, 11 Sep 2019, Jeff Hostetler wrote: > On 9/10/2019 9:54 AM, Garima Singh wrote: > > Ping :) Any thoughts on this? > > > > On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote: > > > Emit trace2_cmd_mode() messages for each commit-graph sub-command. > > > > > > The commit graph commands were in flux when trace2 was making it's way to > > > git. Now that we have enough sub-commands in commit-graph, we can label > > > the > > > various modes within them. Distinguishing between read, write and verify > > > is > > > a great start. > > > > > > Signed-off-by: Garima Singh garima.singh@microsoft.com > > > [garima.singh@microsoft.com] > > > > > > CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com, > > > avarab@gmail.com > > > > > > Garima Singh (1): > > >    commit-graph: emit trace2 cmd_mode for each sub-command > > > > > >   builtin/commit-graph.c | 6 ++++++ > > >   1 file changed, 6 insertions(+) > > > > > > > > > base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26 > > > Published-As: > > > https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1 > > > > > > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git > > > pr-323/garimasi514/coreGit-commit-graph-trace2-v1 > > > Pull-Request: https://github.com/gitgitgadget/git/pull/323 > > > > > Looks good to me. Thanks! This was not yet picked up into `pu`, correct? Or did I miss anything? Ciao, Dscho > > Signed-off-by: Jeff Hostetler > > ```