threads / patch / 5134

patch, 4 partsgitweb: blame table row no highlight fix

Subject: [PATCH 1/4] gitweb: blame table row no highlight fix

## tl;dr

3 messages between Aug 4, 2006 and Aug 5, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Luben Tuikov· Aug 4, 2006, 22:09 UTC · lore

Until now blame just used the commit/tree/tags/etc style of highlight-able table rows, which have strictly alternating light/dark rows. This is very annoying in blame, since the text is static and it interferes with the per-revision block highlight.

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
 gitweb/gitweb.css  |    4 ++++
 gitweb/gitweb.perl |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

Show changes to 2 files +5 −1

gitweb/gitweb.css, gitweb/gitweb.perl

diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index 460e728..47c1ade 100644
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css
@@ -171,6 +171,10 @@ tr.dark {
 	background-color: #f6f6f0;
 }
 
+tr.dark2 {
+	background-color: #f6f6f0;
+}
+
 tr.dark:hover {
 	background-color: #edece6;
 }
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 58eb5b1..049f27e 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1493,7 +1493,7 @@ sub git_blame2 {
 	git_page_nav('','', $hash_base,$co{'tree'},$hash_base, $formats_nav);
 	git_header_div('commit', esc_html($co{'title'}), $hash_base);
 	git_print_page_path($file_name, $ftype);
-	my @rev_color = (qw(light dark));
+	my @rev_color = (qw(light2 dark2));
 	my $num_colors = scalar(@rev_color);
 	my $current_color = 0;
 	my $last_rev;

-- 
1.4.2.rc3.g6df3

Junio C Hamano· Aug 4, 2006, 23:58 UTC · re: Luben Tuikov · lore

Re: [PATCH 1/4] gitweb: blame table row no highlight fix

Luben Tuikov <ltuikov@yahoo.com> writes:

Show 40 quoted lines

> Until now blame just used the commit/tree/tags/etc style of
> highlight-able table rows, which have strictly alternating
> light/dark rows. This is very annoying in blame, since the
> text is static and it interferes with the per-revision block
> highlight.
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> ---
>  gitweb/gitweb.css  |    4 ++++
>  gitweb/gitweb.perl |    2 +-
>  2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
> index 460e728..47c1ade 100644
> --- a/gitweb/gitweb.css
> +++ b/gitweb/gitweb.css
> @@ -171,6 +171,10 @@ tr.dark {
>  	background-color: #f6f6f0;
>  }
>  
> +tr.dark2 {
> +	background-color: #f6f6f0;
> +}
> +
>  tr.dark:hover {
>  	background-color: #edece6;
>  }
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 58eb5b1..049f27e 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1493,7 +1493,7 @@ sub git_blame2 {
>  	git_page_nav('','', $hash_base,$co{'tree'},$hash_base, $formats_nav);
>  	git_header_div('commit', esc_html($co{'title'}), $hash_base);
>  	git_print_page_path($file_name, $ftype);
> -	my @rev_color = (qw(light dark));
> +	my @rev_color = (qw(light2 dark2));
>  	my $num_colors = scalar(@rev_color);
>  	my $current_color = 0;
>  	my $last_rev;

I do not see "tr.light" but "tr.light:hover" in the original CSS. That is kind of understandable (unhovered light ones just use default), but this patch completely lost me. You use light2 class but nothing affects that class in the CSS.

Maybe it is the commit log message that is misleading? I guess what you are trying to achieve is to disable the color change that follows the pointer?

Luben Tuikov· Aug 5, 2006, 00:51 UTC · re: Junio C Hamano · lore

Re: [PATCH 1/4] gitweb: blame table row no highlight fix

--- Junio C Hamano <junkio@cox.net> wrote:

> I do not see "tr.light" but "tr.light:hover" in the original
> CSS.  That is kind of understandable (unhovered light ones just
> use default), but this patch completely lost me.  You use light2
> class but nothing affects that class in the CSS.

Yes, it is the default, just as there is no "tr.light", there is no "tr.light2".

> Maybe it is the commit log message that is misleading?  I guess
> what you are trying to achieve is to disable the color change
> that follows the pointer?

Yes, indeed.  It is very annoying.

   Luben