git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] gitweb: blame table row no highlight fix

From
Junio C Hamano <junkio@cox.net>
Date
Aug 4, 2006, 23:58 UTC
Message-ID
<7v4pwshx3h.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20060804220959.8423.qmail@web31810.mail.mud.yahoo.com>
Luben Tuikov <ltuikov@yahoo.com> writes:
Show 40 quoted lines
> Until now blame just used the commit/tree/tags/etc style of
> highlight-able table rows, which have strictly alternating
> light/dark rows. This is very annoying in blame, since the
> text is static and it interferes with the per-revision block
> highlight.
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> ---
>  gitweb/gitweb.css  |    4 ++++
>  gitweb/gitweb.perl |    2 +-
>  2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
> index 460e728..47c1ade 100644
> --- a/gitweb/gitweb.css
> +++ b/gitweb/gitweb.css
> @@ -171,6 +171,10 @@ tr.dark {
>  	background-color: #f6f6f0;
>  }
>  
> +tr.dark2 {
> +	background-color: #f6f6f0;
> +}
> +
>  tr.dark:hover {
>  	background-color: #edece6;
>  }
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 58eb5b1..049f27e 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1493,7 +1493,7 @@ sub git_blame2 {
>  	git_page_nav('','', $hash_base,$co{'tree'},$hash_base, $formats_nav);
>  	git_header_div('commit', esc_html($co{'title'}), $hash_base);
>  	git_print_page_path($file_name, $ftype);
> -	my @rev_color = (qw(light dark));
> +	my @rev_color = (qw(light2 dark2));
>  	my $num_colors = scalar(@rev_color);
>  	my $current_color = 0;
>  	my $last_rev;

I do not see "tr.light" but "tr.light:hover" in the original CSS. That is kind of understandable (unhovered light ones just use default), but this patch completely lost me. You use light2 class but nothing affects that class in the CSS.

Maybe it is the commit log message that is misleading? I guess what you are trying to achieve is to disable the color change that follows the pointer?

Previous: Luben TuikovNext: Luben Tuikov
Message 2 of 3 in “gitweb: blame table row no highlight fix”
  1. 1/4 gitweb: blame table row no highlight fixLuben Tuikov, Aug 4, 2006
  2. Junio C HamanoAug 4, 2006
  3. Luben TuikovAug 5, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.