{"thread":{"id":"5134","subject":"[PATCH 1/4] gitweb: blame table row no highlight fix","startedAt":"2006-08-04T22:09:59Z","lastAt":"2006-08-05T00:51:48Z","messageCount":3,"participants":["Luben Tuikov","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"24763","messageId":"20060804220959.8423.qmail@web31810.mail.mud.yahoo.com","threadId":"5134","inReplyTo":null,"subject":"[PATCH 1/4] gitweb: blame table row no highlight fix","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-08-04T22:09:59Z","receivedAt":"2006-08-04T22:09:59Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Until now blame just used the commit/tree/tags/etc style of\nhighlight-able table rows, which have strictly alternating\nlight/dark rows. This is very annoying in blame, since the\ntext is static and it interferes with the per-revision block\nhighlight.\n\nSigned-off-by: Luben Tuikov <ltuikov@yahoo.com>\n---\n gitweb/gitweb.css  |    4 ++++\n gitweb/gitweb.perl |    2 +-\n 2 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 460e728..47c1ade 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -171,6 +171,10 @@ tr.dark {\n \tbackground-color: #f6f6f0;\n }\n \n+tr.dark2 {\n+\tbackground-color: #f6f6f0;\n+}\n+\n tr.dark:hover {\n \tbackground-color: #edece6;\n }\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 58eb5b1..049f27e 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1493,7 +1493,7 @@ sub git_blame2 {\n \tgit_page_nav('','', $hash_base,$co{'tree'},$hash_base, $formats_nav);\n \tgit_header_div('commit', esc_html($co{'title'}), $hash_base);\n \tgit_print_page_path($file_name, $ftype);\n-\tmy @rev_color = (qw(light dark));\n+\tmy @rev_color = (qw(light2 dark2));\n \tmy $num_colors = scalar(@rev_color);\n \tmy $current_color = 0;\n \tmy $last_rev;\n-- \n1.4.2.rc3.g6df3\n"},{"id":"24778","messageId":"7v4pwshx3h.fsf@assigned-by-dhcp.cox.net","threadId":"5134","inReplyTo":"20060804220959.8423.qmail@web31810.mail.mud.yahoo.com","subject":"Re: [PATCH 1/4] gitweb: blame table row no highlight fix","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-04T23:58:42Z","receivedAt":"2006-08-04T23:58:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov <ltuikov@yahoo.com> writes:\n\n> Until now blame just used the commit/tree/tags/etc style of\n> highlight-able table rows, which have strictly alternating\n> light/dark rows. This is very annoying in blame, since the\n> text is static and it interferes with the per-revision block\n> highlight.\n>\n> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>\n> ---\n>  gitweb/gitweb.css  |    4 ++++\n>  gitweb/gitweb.perl |    2 +-\n>  2 files changed, 5 insertions(+), 1 deletions(-)\n>\n> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\n> index 460e728..47c1ade 100644\n> --- a/gitweb/gitweb.css\n> +++ b/gitweb/gitweb.css\n> @@ -171,6 +171,10 @@ tr.dark {\n>  \tbackground-color: #f6f6f0;\n>  }\n>  \n> +tr.dark2 {\n> +\tbackground-color: #f6f6f0;\n> +}\n> +\n>  tr.dark:hover {\n>  \tbackground-color: #edece6;\n>  }\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 58eb5b1..049f27e 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -1493,7 +1493,7 @@ sub git_blame2 {\n>  \tgit_page_nav('','', $hash_base,$co{'tree'},$hash_base, $formats_nav);\n>  \tgit_header_div('commit', esc_html($co{'title'}), $hash_base);\n>  \tgit_print_page_path($file_name, $ftype);\n> -\tmy @rev_color = (qw(light dark));\n> +\tmy @rev_color = (qw(light2 dark2));\n>  \tmy $num_colors = scalar(@rev_color);\n>  \tmy $current_color = 0;\n>  \tmy $last_rev;\n\nI do not see \"tr.light\" but \"tr.light:hover\" in the original\nCSS.  That is kind of understandable (unhovered light ones just\nuse default), but this patch completely lost me.  You use light2\nclass but nothing affects that class in the CSS.\n\nMaybe it is the commit log message that is misleading?  I guess\nwhat you are trying to achieve is to disable the color change\nthat follows the pointer?\n"},{"id":"24784","messageId":"20060805005148.12923.qmail@web31807.mail.mud.yahoo.com","threadId":"5134","inReplyTo":"7v4pwshx3h.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 1/4] gitweb: blame table row no highlight fix","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-08-05T00:51:48Z","receivedAt":"2006-08-05T00:51:48Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Junio C Hamano <junkio@cox.net> wrote:\n> I do not see \"tr.light\" but \"tr.light:hover\" in the original\n> CSS.  That is kind of understandable (unhovered light ones just\n> use default), but this patch completely lost me.  You use light2\n> class but nothing affects that class in the CSS.\n\nYes, it is the default, just as there is no \"tr.light\", there is\nno \"tr.light2\".\n\n> Maybe it is the commit log message that is misleading?  I guess\n> what you are trying to achieve is to disable the color change\n> that follows the pointer?\n\nYes, indeed.  It is very annoying.\n\n   Luben\n"}]}