threads / patch / 50875

patchpromisor-remote.h: fix an 'hdr-check' warning

Subject: [PATCH] promisor-remote.h: fix an 'hdr-check' warning

## tl;dr

3 messages between Apr 4, 2019 and Apr 5, 2019. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Ramsay Jones· Apr 4, 2019, 18:57 UTC · lore
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Christian,

If you need to re-roll your 'cc/multi-promisor' branch, could you please squash this into the relevant patch (commit e52d417b57 ("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).

[I had a deja-vu moment writing this - it seems I sent a very similar mail about 3 weeks ago. ;-) ]

Thanks!

ATB, Ramsay Jones

 promisor-remote.h | 2 ++
 1 file changed, 2 insertions(+)
Show changes to promisor-remote.h +2 −0
diff --git a/promisor-remote.h b/promisor-remote.h
index e29cf507ab..562c7ad8a4 100644
--- a/promisor-remote.h
+++ b/promisor-remote.h
@@ -1,6 +1,8 @@
 #ifndef PROMISOR_REMOTE_H
 #define PROMISOR_REMOTE_H
 
+struct object_id;
+
 /*
  * Promisor remote linked list
  *

-- 
2.21.0
Christian Couder· Apr 4, 2019, 21:55 UTC · re: Ramsay Jones · lore

Re: [PATCH] promisor-remote.h: fix an 'hdr-check' warning

Hi Ramsay,
On Thu, Apr 4, 2019 at 8:59 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
Show 6 quoted lines
> If you need to re-roll your 'cc/multi-promisor' branch, could you
> please squash this into the relevant patch (commit e52d417b57
> ("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).
>
> [I had a deja-vu moment writing this - it seems I sent a very
> similar mail about 3 weeks ago. ;-) ]

Yeah, sorry. I don't know why but I failed to notice your previous email about this.

I have integrated the change you suggest in my patch series so it should be in the next version.

Thanks again, Christian.

Junio C Hamano· Apr 5, 2019, 05:44 UTC · re: Christian Couder · lore

Re: [PATCH] promisor-remote.h: fix an 'hdr-check' warning

Christian Couder <christian.couder@gmail.com> writes:
Show 19 quoted lines
> Hi Ramsay,
>
> On Thu, Apr 4, 2019 at 8:59 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
>
>> If you need to re-roll your 'cc/multi-promisor' branch, could you
>> please squash this into the relevant patch (commit e52d417b57
>> ("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).
>>
>> [I had a deja-vu moment writing this - it seems I sent a very
>> similar mail about 3 weeks ago. ;-) ]
>
> Yeah, sorry. I don't know why but I failed to notice your previous
> email about this.
>
> I have integrated the change you suggest in my patch series so it
> should be in the next version.
>
> Thanks again,
> Christian.
Thanks, both.

← back to recent threads