# [PATCH] promisor-remote.h: fix an 'hdr-check' warning

3 messages from 2019-04-04 to 2019-04-05. Participants: Ramsay Jones, Christian Couder, Junio C Hamano.
Thread: https://gitlist.dev/t/50875

## Ramsay Jones, 2019-04-04 18:57

Subject: [PATCH] promisor-remote.h: fix an 'hdr-check' warning
Message-ID: <0830dd3a-551e-8d74-18cf-288ef05ec287@ramsayjones.plus.com>
URL: https://gitlist.dev/e/0830dd3a-551e-8d74-18cf-288ef05ec287%40ramsayjones.plus.com

```

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Christian,

If you need to re-roll your 'cc/multi-promisor' branch, could you
please squash this into the relevant patch (commit e52d417b57
("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).

[I had a deja-vu moment writing this - it seems I sent a very
similar mail about 3 weeks ago. ;-) ]

Thanks!

ATB,
Ramsay Jones

 promisor-remote.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/promisor-remote.h b/promisor-remote.h
index e29cf507ab..562c7ad8a4 100644
--- a/promisor-remote.h
+++ b/promisor-remote.h
@@ -1,6 +1,8 @@
 #ifndef PROMISOR_REMOTE_H
 #define PROMISOR_REMOTE_H
 
+struct object_id;
+
 /*
  * Promisor remote linked list
  *
-- 
2.21.0

```

## Christian Couder, 2019-04-04 21:55

Subject: Re: [PATCH] promisor-remote.h: fix an 'hdr-check' warning
Message-ID: <CAP8UFD267N_zaomOD_-_1YnyKpGu7jDuEjyRW0sc3Y6Wjo2xRA@mail.gmail.com>
URL: https://gitlist.dev/e/CAP8UFD267N_zaomOD_-_1YnyKpGu7jDuEjyRW0sc3Y6Wjo2xRA%40mail.gmail.com
In-Reply-To: <0830dd3a-551e-8d74-18cf-288ef05ec287@ramsayjones.plus.com>

```
Hi Ramsay,

On Thu, Apr 4, 2019 at 8:59 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

> If you need to re-roll your 'cc/multi-promisor' branch, could you
> please squash this into the relevant patch (commit e52d417b57
> ("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).
>
> [I had a deja-vu moment writing this - it seems I sent a very
> similar mail about 3 weeks ago. ;-) ]

Yeah, sorry. I don't know why but I failed to notice your previous
email about this.

I have integrated the change you suggest in my patch series so it
should be in the next version.

Thanks again,
Christian.

```

## Junio C Hamano, 2019-04-05 05:44

Subject: Re: [PATCH] promisor-remote.h: fix an 'hdr-check' warning
Message-ID: <xmqqtvfdc8g9.fsf@gitster-ct.c.googlers.com>
URL: https://gitlist.dev/e/xmqqtvfdc8g9.fsf%40gitster-ct.c.googlers.com
In-Reply-To: <CAP8UFD267N_zaomOD_-_1YnyKpGu7jDuEjyRW0sc3Y6Wjo2xRA@mail.gmail.com>

```
Christian Couder <christian.couder@gmail.com> writes:

> Hi Ramsay,
>
> On Thu, Apr 4, 2019 at 8:59 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
>
>> If you need to re-roll your 'cc/multi-promisor' branch, could you
>> please squash this into the relevant patch (commit e52d417b57
>> ("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).
>>
>> [I had a deja-vu moment writing this - it seems I sent a very
>> similar mail about 3 weeks ago. ;-) ]
>
> Yeah, sorry. I don't know why but I failed to notice your previous
> email about this.
>
> I have integrated the change you suggest in my patch series so it
> should be in the next version.
>
> Thanks again,
> Christian.

Thanks, both.

```