{"thread":{"id":"50875","subject":"[PATCH] promisor-remote.h: fix an 'hdr-check' warning","startedAt":"2019-04-04T18:57:20Z","lastAt":"2019-04-05T05:44:55Z","messageCount":3,"participants":["Ramsay Jones","Christian Couder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"373130","messageId":"0830dd3a-551e-8d74-18cf-288ef05ec287@ramsayjones.plus.com","threadId":"50875","inReplyTo":null,"subject":"[PATCH] promisor-remote.h: fix an 'hdr-check' warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2019-04-04T18:57:14Z","receivedAt":"2019-04-04T18:57:20Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Christian,\n\nIf you need to re-roll your 'cc/multi-promisor' branch, could you\nplease squash this into the relevant patch (commit e52d417b57\n(\"promisor-remote: implement promisor_remote_get_direct()\", 2019-04-01)).\n\n[I had a deja-vu moment writing this - it seems I sent a very\nsimilar mail about 3 weeks ago. ;-) ]\n\nThanks!\n\nATB,\nRamsay Jones\n\n promisor-remote.h | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/promisor-remote.h b/promisor-remote.h\nindex e29cf507ab..562c7ad8a4 100644\n--- a/promisor-remote.h\n+++ b/promisor-remote.h\n@@ -1,6 +1,8 @@\n #ifndef PROMISOR_REMOTE_H\n #define PROMISOR_REMOTE_H\n \n+struct object_id;\n+\n /*\n  * Promisor remote linked list\n  *\n-- \n2.21.0\n"},{"id":"373135","messageId":"CAP8UFD267N_zaomOD_-_1YnyKpGu7jDuEjyRW0sc3Y6Wjo2xRA@mail.gmail.com","threadId":"50875","inReplyTo":"0830dd3a-551e-8d74-18cf-288ef05ec287@ramsayjones.plus.com","subject":"Re: [PATCH] promisor-remote.h: fix an 'hdr-check' warning","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2019-04-04T21:55:06Z","receivedAt":"2019-04-04T21:55:21Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Hi Ramsay,\n\nOn Thu, Apr 4, 2019 at 8:59 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:\n\n> If you need to re-roll your 'cc/multi-promisor' branch, could you\n> please squash this into the relevant patch (commit e52d417b57\n> (\"promisor-remote: implement promisor_remote_get_direct()\", 2019-04-01)).\n>\n> [I had a deja-vu moment writing this - it seems I sent a very\n> similar mail about 3 weeks ago. ;-) ]\n\nYeah, sorry. I don't know why but I failed to notice your previous\nemail about this.\n\nI have integrated the change you suggest in my patch series so it\nshould be in the next version.\n\nThanks again,\nChristian.\n"},{"id":"373183","messageId":"xmqqtvfdc8g9.fsf@gitster-ct.c.googlers.com","threadId":"50875","inReplyTo":"CAP8UFD267N_zaomOD_-_1YnyKpGu7jDuEjyRW0sc3Y6Wjo2xRA@mail.gmail.com","subject":"Re: [PATCH] promisor-remote.h: fix an 'hdr-check' warning","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-04-05T05:44:22Z","receivedAt":"2019-04-05T05:44:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christian Couder <christian.couder@gmail.com> writes:\n\n> Hi Ramsay,\n>\n> On Thu, Apr 4, 2019 at 8:59 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:\n>\n>> If you need to re-roll your 'cc/multi-promisor' branch, could you\n>> please squash this into the relevant patch (commit e52d417b57\n>> (\"promisor-remote: implement promisor_remote_get_direct()\", 2019-04-01)).\n>>\n>> [I had a deja-vu moment writing this - it seems I sent a very\n>> similar mail about 3 weeks ago. ;-) ]\n>\n> Yeah, sorry. I don't know why but I failed to notice your previous\n> email about this.\n>\n> I have integrated the change you suggest in my patch series so it\n> should be in the next version.\n>\n> Thanks again,\n> Christian.\n\nThanks, both.\n"}]}