threads / patch / 50583

patcht5580: verify that alternates can be UNC paths

Subject: [PATCH 0/1] t5580: verify that alternates can be UNC paths

## tl;dr

4 messages between Feb 25, 2019 and May 7, 2019. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Johannes Schindelin via GitGitGadget· Feb 25, 2019, 14:17 UTC · lore

This was fixed in git.git's master some time ago, unfortunately not upstreamed from Git for Windows' patch thicket (my fault, or better put: the fault of the twenty-four hour days not being longer). We carried a regression test on top of the fix, and I can at least contribute that.

Johannes Schindelin (1):
  t5580: verify that alternates can be UNC paths

 t/t5580-clone-push-unc.sh | 12 ++++++++++++
 1 file changed, 12 insertions(+)

base-commit: 8104ec994ea3849a968b4667d072fedd1e688642
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-140%2Fdscho%2Ftest-unc-alternates-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-140/dscho/test-unc-alternates-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/140

-- 
gitgitgadget

Johannes Schindelin via GitGitGadget· Feb 25, 2019, 14:17 UTC · re: Johannes Schindelin via GitGitGadget · lore

[PATCH 1/1] t5580: verify that alternates can be UNC paths

From: Johannes Schindelin <johannes.schindelin@gmx.de>

On Windows, UNC paths are a very convenient way to share data, and alternates are all about sharing data.

We fixed a bug where alternates specifying UNC paths were not handled properly, and it is high time that we add a regression test to ensure that this bug is not reintroduced.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t5580-clone-push-unc.sh | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Show changes to t/t5580-clone-push-unc.sh +12 −0

diff --git a/t/t5580-clone-push-unc.sh b/t/t5580-clone-push-unc.sh
index 217adf3a63..b3c8a92450 100755
--- a/t/t5580-clone-push-unc.sh
+++ b/t/t5580-clone-push-unc.sh
@@ -62,4 +62,16 @@ test_expect_success MINGW 'remote nick cannot contain backslashes' '
 	test_i18ngrep ! "unable to access" err
 '
 
+test_expect_success 'unc alternates' '
+	tree="$(git rev-parse HEAD:)" &&
+	mkdir test-unc-alternate &&
+	(
+		cd test-unc-alternate &&
+		git init &&
+		test_must_fail git show $tree &&
+		echo "$UNCPATH/.git/objects" >.git/objects/info/alternates &&
+		git show $tree
+	)
+'
+
 test_done

-- 
gitgitgadget

Johannes Schindelin· Apr 29, 2019, 22:52 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH 1/1] t5580: verify that alternates can be UNC paths

Hi Junio,

gentle ping: this patch was not picked up yet, although it should be pretty uncontroversial.

Ciao, Dscho

On Mon, 25 Feb 2019, Johannes Schindelin via GitGitGadget wrote:

Show 39 quoted lines

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> On Windows, UNC paths are a very convenient way to share data, and
> alternates are all about sharing data.
>
> We fixed a bug where alternates specifying UNC paths were not handled
> properly, and it is high time that we add a regression test to ensure
> that this bug is not reintroduced.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  t/t5580-clone-push-unc.sh | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/t/t5580-clone-push-unc.sh b/t/t5580-clone-push-unc.sh
> index 217adf3a63..b3c8a92450 100755
> --- a/t/t5580-clone-push-unc.sh
> +++ b/t/t5580-clone-push-unc.sh
> @@ -62,4 +62,16 @@ test_expect_success MINGW 'remote nick cannot contain backslashes' '
>  	test_i18ngrep ! "unable to access" err
>  '
>
> +test_expect_success 'unc alternates' '
> +	tree="$(git rev-parse HEAD:)" &&
> +	mkdir test-unc-alternate &&
> +	(
> +		cd test-unc-alternate &&
> +		git init &&
> +		test_must_fail git show $tree &&
> +		echo "$UNCPATH/.git/objects" >.git/objects/info/alternates &&
> +		git show $tree
> +	)
> +'
> +
>  test_done
> --
> gitgitgadget
>
>

Junio C Hamano· May 7, 2019, 09:41 UTC · re: Johannes Schindelin · lore

Re: [PATCH 1/1] t5580: verify that alternates can be UNC paths

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi Junio,
>
> gentle ping: this patch was not picked up yet, although it should be
> pretty uncontroversial.

Thanks. It does look it fell through the cracks without sound. Will pick it up.