{"thread":{"id":"50583","subject":"[PATCH 0/1] t5580: verify that alternates can be UNC paths","startedAt":"2019-02-25T14:17:48Z","lastAt":"2019-05-07T09:41:18Z","messageCount":4,"participants":["Johannes Schindelin via GitGitGadget","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"370113","messageId":"pull.140.git.gitgitgadget@gmail.com","threadId":"50583","inReplyTo":null,"subject":"[PATCH 0/1] t5580: verify that alternates can be UNC paths","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-02-25T14:17:44Z","receivedAt":"2019-02-25T14:17:48Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"This was fixed in git.git's master some time ago, unfortunately not\nupstreamed from Git for Windows' patch thicket (my fault, or better put: the\nfault of the twenty-four hour days not being longer). We carried a\nregression test on top of the fix, and I can at least contribute that.\n\nJohannes Schindelin (1):\n t5580: verify that alternates can be UNC paths\n\n t/t5580-clone-push-unc.sh | 12 ++++++++++++\n 1 file changed, 12 insertions(+)\n\n\nbase-commit: 8104ec994ea3849a968b4667d072fedd1e688642\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-140%2Fdscho%2Ftest-unc-alternates-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-140/dscho/test-unc-alternates-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/140\n-- \ngitgitgadget\n"},{"id":"370114","messageId":"2c3c559da0a5e9b397f4dc80be233c66b8597678.1551104263.git.gitgitgadget@gmail.com","threadId":"50583","inReplyTo":"pull.140.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] t5580: verify that alternates can be UNC paths","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-02-25T14:17:45Z","receivedAt":"2019-02-25T14:17:49Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nOn Windows, UNC paths are a very convenient way to share data, and\nalternates are all about sharing data.\n\nWe fixed a bug where alternates specifying UNC paths were not handled\nproperly, and it is high time that we add a regression test to ensure\nthat this bug is not reintroduced.\n\nSigned-off-by: Johannes Schindelin \n---\n t/t5580-clone-push-unc.sh | 12 ++++++++++++\n 1 file changed, 12 insertions(+)\n\ndiff --git a/t/t5580-clone-push-unc.sh b/t/t5580-clone-push-unc.sh\nindex 217adf3a63..b3c8a92450 100755\n--- a/t/t5580-clone-push-unc.sh\n+++ b/t/t5580-clone-push-unc.sh\n@@ -62,4 +62,16 @@ test_expect_success MINGW 'remote nick cannot contain backslashes' '\n \ttest_i18ngrep ! \"unable to access\" err\n '\n \n+test_expect_success 'unc alternates' '\n+\ttree=\"$(git rev-parse HEAD:)\" &&\n+\tmkdir test-unc-alternate &&\n+\t(\n+\t\tcd test-unc-alternate &&\n+\t\tgit init &&\n+\t\ttest_must_fail git show $tree &&\n+\t\techo \"$UNCPATH/.git/objects\" >.git/objects/info/alternates &&\n+\t\tgit show $tree\n+\t)\n+'\n+\n test_done\n-- \ngitgitgadget\n"},{"id":"374683","messageId":"nycvar.QRO.7.76.6.1904291851280.45@tvgsbejvaqbjf.bet","threadId":"50583","inReplyTo":"2c3c559da0a5e9b397f4dc80be233c66b8597678.1551104263.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] t5580: verify that alternates can be UNC paths","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-04-29T22:52:19Z","receivedAt":"2019-04-29T22:52:25Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\ngentle ping: this patch was not picked up yet, although it should be\npretty uncontroversial.\n\nCiao,\nDscho\n\nOn Mon, 25 Feb 2019, Johannes Schindelin via GitGitGadget wrote:\n\n> From: Johannes Schindelin \n>\n> On Windows, UNC paths are a very convenient way to share data, and\n> alternates are all about sharing data.\n>\n> We fixed a bug where alternates specifying UNC paths were not handled\n> properly, and it is high time that we add a regression test to ensure\n> that this bug is not reintroduced.\n>\n> Signed-off-by: Johannes Schindelin \n> ---\n> t/t5580-clone-push-unc.sh | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n>\n> diff --git a/t/t5580-clone-push-unc.sh b/t/t5580-clone-push-unc.sh\n> index 217adf3a63..b3c8a92450 100755\n> --- a/t/t5580-clone-push-unc.sh\n> +++ b/t/t5580-clone-push-unc.sh\n> @@ -62,4 +62,16 @@ test_expect_success MINGW 'remote nick cannot contain backslashes' '\n> \ttest_i18ngrep ! \"unable to access\" err\n> '\n>\n> +test_expect_success 'unc alternates' '\n> +\ttree=\"$(git rev-parse HEAD:)\" &&\n> +\tmkdir test-unc-alternate &&\n> +\t(\n> +\t\tcd test-unc-alternate &&\n> +\t\tgit init &&\n> +\t\ttest_must_fail git show $tree &&\n> +\t\techo \"$UNCPATH/.git/objects\" >.git/objects/info/alternates &&\n> +\t\tgit show $tree\n> +\t)\n> +'\n> +\n> test_done\n> --\n> gitgitgadget\n>\n>\n"},{"id":"375003","messageId":"xmqqpnoulhzd.fsf@gitster-ct.c.googlers.com","threadId":"50583","inReplyTo":"nycvar.QRO.7.76.6.1904291851280.45@tvgsbejvaqbjf.bet","subject":"Re: [PATCH 1/1] t5580: verify that alternates can be UNC paths","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-05-07T09:41:10Z","receivedAt":"2019-05-07T09:41:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi Junio,\n>\n> gentle ping: this patch was not picked up yet, although it should be\n> pretty uncontroversial.\n\nThanks. It does look it fell through the cracks without sound.\nWill pick it up.\n"}]}