# [PATCH 0/1] t5580: verify that alternates can be UNC paths 4 messages from 2019-02-25 to 2019-05-07. Participants: Johannes Schindelin via GitGitGadget, Johannes Schindelin, Junio C Hamano. Thread: https://gitlist.dev/t/50583 ## Johannes Schindelin via GitGitGadget, 2019-02-25 14:17 Subject: [PATCH 0/1] t5580: verify that alternates can be UNC paths Message-ID: URL: https://gitlist.dev/e/pull.140.git.gitgitgadget%40gmail.com ``` This was fixed in git.git's master some time ago, unfortunately not upstreamed from Git for Windows' patch thicket (my fault, or better put: the fault of the twenty-four hour days not being longer). We carried a regression test on top of the fix, and I can at least contribute that. Johannes Schindelin (1): t5580: verify that alternates can be UNC paths t/t5580-clone-push-unc.sh | 12 ++++++++++++ 1 file changed, 12 insertions(+) base-commit: 8104ec994ea3849a968b4667d072fedd1e688642 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-140%2Fdscho%2Ftest-unc-alternates-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-140/dscho/test-unc-alternates-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/140 -- gitgitgadget ``` ## Johannes Schindelin via GitGitGadget, 2019-02-25 14:17 Subject: [PATCH 1/1] t5580: verify that alternates can be UNC paths Message-ID: <2c3c559da0a5e9b397f4dc80be233c66b8597678.1551104263.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/2c3c559da0a5e9b397f4dc80be233c66b8597678.1551104263.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Johannes Schindelin On Windows, UNC paths are a very convenient way to share data, and alternates are all about sharing data. We fixed a bug where alternates specifying UNC paths were not handled properly, and it is high time that we add a regression test to ensure that this bug is not reintroduced. Signed-off-by: Johannes Schindelin --- t/t5580-clone-push-unc.sh | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/t/t5580-clone-push-unc.sh b/t/t5580-clone-push-unc.sh index 217adf3a63..b3c8a92450 100755 --- a/t/t5580-clone-push-unc.sh +++ b/t/t5580-clone-push-unc.sh @@ -62,4 +62,16 @@ test_expect_success MINGW 'remote nick cannot contain backslashes' ' test_i18ngrep ! "unable to access" err ' +test_expect_success 'unc alternates' ' + tree="$(git rev-parse HEAD:)" && + mkdir test-unc-alternate && + ( + cd test-unc-alternate && + git init && + test_must_fail git show $tree && + echo "$UNCPATH/.git/objects" >.git/objects/info/alternates && + git show $tree + ) +' + test_done -- gitgitgadget ``` ## Johannes Schindelin, 2019-04-29 22:52 Subject: Re: [PATCH 1/1] t5580: verify that alternates can be UNC paths Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.1904291851280.45%40tvgsbejvaqbjf.bet In-Reply-To: <2c3c559da0a5e9b397f4dc80be233c66b8597678.1551104263.git.gitgitgadget@gmail.com> ``` Hi Junio, gentle ping: this patch was not picked up yet, although it should be pretty uncontroversial. Ciao, Dscho On Mon, 25 Feb 2019, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > On Windows, UNC paths are a very convenient way to share data, and > alternates are all about sharing data. > > We fixed a bug where alternates specifying UNC paths were not handled > properly, and it is high time that we add a regression test to ensure > that this bug is not reintroduced. > > Signed-off-by: Johannes Schindelin > --- > t/t5580-clone-push-unc.sh | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/t/t5580-clone-push-unc.sh b/t/t5580-clone-push-unc.sh > index 217adf3a63..b3c8a92450 100755 > --- a/t/t5580-clone-push-unc.sh > +++ b/t/t5580-clone-push-unc.sh > @@ -62,4 +62,16 @@ test_expect_success MINGW 'remote nick cannot contain backslashes' ' > test_i18ngrep ! "unable to access" err > ' > > +test_expect_success 'unc alternates' ' > + tree="$(git rev-parse HEAD:)" && > + mkdir test-unc-alternate && > + ( > + cd test-unc-alternate && > + git init && > + test_must_fail git show $tree && > + echo "$UNCPATH/.git/objects" >.git/objects/info/alternates && > + git show $tree > + ) > +' > + > test_done > -- > gitgitgadget > > ``` ## Junio C Hamano, 2019-05-07 09:41 Subject: Re: [PATCH 1/1] t5580: verify that alternates can be UNC paths Message-ID: URL: https://gitlist.dev/e/xmqqpnoulhzd.fsf%40gitster-ct.c.googlers.com In-Reply-To: ``` Johannes Schindelin writes: > Hi Junio, > > gentle ping: this patch was not picked up yet, although it should be > pretty uncontroversial. Thanks. It does look it fell through the cracks without sound. Will pick it up. ```