threads / patch / 49971

patchmailmap: update brandon williams's email address

Subject: [PATCH] mailmap: update brandon williams's email address

## tl;dr

12 messages between Dec 7, 2018 and Jan 18, 2019. Diffs are folded; open one to read it.

replies: 11people: 8as markdown or json

Brandon Williams· Dec 7, 2018, 20:56 UTC · lore
Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com>
---
 .mailmap | 1 +
 1 file changed, 1 insertion(+)
Show changes to .mailmap +1 −0
diff --git a/.mailmap b/.mailmap
index eb7b5fc7b..247a3deb7 100644
--- a/.mailmap
+++ b/.mailmap
@@ -27,6 +27,7 @@ Ben Walton <bdwalton@gmail.com> <bwalton@artsci.utoronto.ca>
 Benoit Sigoure <tsunanet@gmail.com> <tsuna@lrde.epita.fr>
 Bernt Hansen <bernt@norang.ca> <bernt@alumni.uwaterloo.ca>
 Brandon Casey <drafnel@gmail.com> <casey@nrlssc.navy.mil>
+Brandon Williams <bwilliams.eng@gmail.com> <bmwill@google.com>
 brian m. carlson <sandals@crustytoothpaste.net>
 brian m. carlson <sandals@crustytoothpaste.net> <sandals@crustytoothpaste.ath.cx>
 Bryan Larsen <bryan@larsen.st> <bryan.larsen@gmail.com>

-- 
2.19.1
Jonathan Nieder· Dec 7, 2018, 21:40 UTC · re: Brandon Williams · lore

Re: [PATCH] mailmap: update brandon williams's email address

Brandon Williams wrote:
> Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com>
> ---
>  .mailmap | 1 +
>  1 file changed, 1 insertion(+)
I can confirm that this is indeed the same person.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Welcome back!
Stefan Beller· Dec 7, 2018, 22:11 UTC · re: Jonathan Nieder · lore

Re: [PATCH] mailmap: update brandon williams's email address

On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 9 quoted lines
>
> Brandon Williams wrote:
>
> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com>
> > ---
> >  .mailmap | 1 +
> >  1 file changed, 1 insertion(+)
>
> I can confirm that this is indeed the same person.

What would be more of interest is why we'd be interested in this patch as there is no commit/patch sent by Brandon with this email in gits history.

Is that so you get cc'd on your private address and can follow things you worked on without being subscribed to the mailing list? (I'd be interested to see the use case in the commit message;)

Thanks, Stefan

Jonathan Nieder· Dec 7, 2018, 22:22 UTC · re: Stefan Beller · lore

Re: [PATCH] mailmap: update brandon williams's email address

Hi,
Stefan Beller wrote:
> What would be more of interest is why we'd be interested in this patch
> as there is no commit/patch sent by Brandon with this email in gits history.

I think there's an implicit assumption in this question that isn't spelled out. Do I understand correctly that you're saying the main purpose of .mailmap is to figure out whether two commits are by the same author?

My own uses of .mailmap primarily have a different purpose: to find out the preferred contact address for the author of a given commit.

Thanks, Jonathan

Jeff King· Jan 18, 2019, 16:57 UTC · re: Jonathan Nieder · lore

Re: [PATCH] mailmap: update brandon williams's email address

On Fri, Dec 07, 2018 at 02:22:25PM -0800, Jonathan Nieder wrote:
Show 12 quoted lines
> Stefan Beller wrote:
> 
> > What would be more of interest is why we'd be interested in this patch
> > as there is no commit/patch sent by Brandon with this email in gits history.
> 
> I think there's an implicit assumption in this question that isn't
> spelled out.  Do I understand correctly that you're saying the main
> purpose of .mailmap is to figure out whether two commits are by the
> same author?
> 
> My own uses of .mailmap primarily have a different purpose: to find
> out the preferred contact address for the author of a given commit.

I just had to cc Brandon and manually look up his email address, which made me wonder what ever happened to this patch. :)

FWIW, I also use mailmap to find contact email addresses, with:
  $ git help who
  'who' is aliased to '!sh -c 'git --no-pager log -1 --format="%an <%aE>" --author="$1" -i' -'

So lacking another such registry, I'd like to add my support for using mailmap for this purpose.

-Peff
Junio C Hamano· Jan 18, 2019, 18:16 UTC · re: Jeff King · lore

Re: [PATCH] mailmap: update brandon williams's email address

Jeff King <peff@peff.net> writes:
> I just had to cc Brandon and manually look up his email address, which
> made me wonder what ever happened to this patch. :)
d076ad13 ("Merge branch 'bw/mailmap'", 2019-01-14)
Jeff King· Jan 18, 2019, 18:38 UTC · re: Junio C Hamano · lore

Re: [PATCH] mailmap: update brandon williams's email address

On Fri, Jan 18, 2019 at 10:16:33AM -0800, Junio C Hamano wrote:
Show 6 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > I just had to cc Brandon and manually look up his email address, which
> > made me wonder what ever happened to this patch. :)
> 
> d076ad13 ("Merge branch 'bw/mailmap'", 2019-01-14)

Oh, heh. False alarm: I was looking up his address after bisecting back to a failure from last year. And my "who" alias walks from the current HEAD. It should probably choose a known-current point like "origin/master".

Sorry for the noise!
-Peff
Junio C Hamano· Dec 8, 2018, 06:08 UTC · re: Stefan Beller · lore

Re: [PATCH] mailmap: update brandon williams's email address

Stefan Beller <sbeller@google.com> writes:
Show 13 quoted lines
> On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
>>
>> Brandon Williams wrote:
>>
>> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com>
>> > ---
>> >  .mailmap | 1 +
>> >  1 file changed, 1 insertion(+)
>>
>> I can confirm that this is indeed the same person.
>
> What would be more of interest is why we'd be interested in this patch
> as there is no commit/patch sent by Brandon with this email in gits history.

Once I "git am" the message that began this thread, there will be a commit under this new ident, so that would be somewhat a moot point.

If this were "Jonathan asked Brandon if we want to record an address we can reach him in our .mailmap file and sent a patch to add one", then the story is different, and I tend to agree with you that such a patch is more or less pointless. That's not the purpose of the mailmap file.

Not until git-send-email learns to use that file to rewrite To/cc/etc to the "canonical" addresses, anyway ;-)

I am not sure if there are people whose "canonical" address to be used as the author is not necessarily the best address they want to get their e-mails at, though. If we can be reasonably sure that the set of such people is empty, then people can take the above mention about send-email as a hint about a low-hanging fruit ;-)

Thanks.
Brandon Williams· Dec 8, 2018, 06:51 UTC · re: Junio C Hamano · lore

Re: [PATCH] mailmap: update brandon williams's email address

On Fri, Dec 7, 2018 at 10:08 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 26 quoted lines
>
> Stefan Beller <sbeller@google.com> writes:
>
> > On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
> >>
> >> Brandon Williams wrote:
> >>
> >> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com>
> >> > ---
> >> >  .mailmap | 1 +
> >> >  1 file changed, 1 insertion(+)
> >>
> >> I can confirm that this is indeed the same person.
> >
> > What would be more of interest is why we'd be interested in this patch
> > as there is no commit/patch sent by Brandon with this email in gits history.
>
> Once I "git am" the message that began this thread, there will be a
> commit under this new ident, so that would be somewhat a moot point.
>
> If this were "Jonathan asked Brandon if we want to record an address
> we can reach him in our .mailmap file and sent a patch to add one",
> then the story is different, and I tend to agree with you that such
> a patch is more or less pointless.  That's not the purpose of the
> mailmap file.
>

Turns out this is exactly the reason :) I've had a couple of people reach out to me asking me to do this because CCing my old email bounces and they've wanted my input/comments on something related to work I've done. If that's not the intended purpose then please ignore this patch

Show 12 quoted lines
> Not until git-send-email learns to use that file to rewrite
> To/cc/etc to the "canonical" addresses, anyway ;-)
>
> I am not sure if there are people whose "canonical" address to be
> used as the author is not necessarily the best address they want to
> get their e-mails at, though.  If we can be reasonably sure that the
> set of such people is empty, then people can take the above mention
> about send-email as a hint about a low-hanging fruit ;-)
>
> Thanks.
>
>
Johannes Schindelin· Dec 10, 2018, 08:36 UTC · re: Brandon Williams · lore

Re: [PATCH] mailmap: update brandon williams's email address

Hi,
On Fri, 7 Dec 2018, Brandon Williams wrote:
Show 35 quoted lines
> On Fri, Dec 7, 2018 at 10:08 PM Junio C Hamano <gitster@pobox.com>
> wrote:
> >
> > Stefan Beller <sbeller@google.com> writes:
> >
> > > On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com>
> > > wrote:
> > >>
> > >> Brandon Williams wrote:
> > >>
> > >> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com>
> > >> > ---
> > >> >  .mailmap | 1 +
> > >> >  1 file changed, 1 insertion(+)
> > >>
> > >> I can confirm that this is indeed the same person.
> > >
> > > What would be more of interest is why we'd be interested in this
> > > patch as there is no commit/patch sent by Brandon with this email in
> > > gits history.
> >
> > Once I "git am" the message that began this thread, there will be a
> > commit under this new ident, so that would be somewhat a moot point.
> >
> > If this were "Jonathan asked Brandon if we want to record an address
> > we can reach him in our .mailmap file and sent a patch to add one",
> > then the story is different, and I tend to agree with you that such a
> > patch is more or less pointless.  That's not the purpose of the
> > mailmap file.
> >
> 
> Turns out this is exactly the reason :) I've had a couple of people
> reach out to me asking me to do this because CCing my old email bounces
> and they've wanted my input/comments on something related to work I've
> done.  If that's not the intended purpose then please ignore this patch

Unless we come up with a better way to indicate the current address of a Git contributor (I seem to remember that David Turner used the same approach after leaving Twitter so that people could Cc: him with the correct address), I suggest that we keep using .mailmap for that purpose.

Thanks, Dscho

Duy Nguyen· Dec 8, 2018, 08:25 UTC · re: Junio C Hamano · lore

Re: [PATCH] mailmap: update brandon williams's email address

On Sat, Dec 8, 2018 at 7:09 AM Junio C Hamano <gitster@pobox.com> wrote:
> If this were "Jonathan asked Brandon if we want to record an address
> we can reach him in our .mailmap file and sent a patch to add one",
Not sure about Jonathan, but I did.
> then the story is different, and I tend to agree with you that such
> a patch is more or less pointless.  That's not the purpose of the
> mailmap file.

Not directly, but when multiple commands use mailmap to show the canonical mail addresses, then it kinda is. When I look back at an old commit message, I may look up the author name and address, which is mapped.

> Not until git-send-email learns to use that file to rewrite
> To/cc/etc to the "canonical" addresses, anyway ;-)

git-send-email does not have to when I copy/paste the address from git-log anyway.

Show 9 quoted lines
> I am not sure if there are people whose "canonical" address to be
> used as the author is not necessarily the best address they want to
> get their e-mails at, though.  If we can be reasonably sure that the
> set of such people is empty, then people can take the above mention
> about send-email as a hint about a low-hanging fruit ;-)
>
> Thanks.
>
>
-- 
Duy
Ævar Arnfjörð Bjarmason· Dec 8, 2018, 12:18 UTC · re: Junio C Hamano · lore

Re: [PATCH] mailmap: update brandon williams's email address

On Sat, Dec 08 2018, Junio C Hamano wrote:
Show 18 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>> On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
>>>
>>> Brandon Williams wrote:
>>>
>>> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com>
>>> > ---
>>> >  .mailmap | 1 +
>>> >  1 file changed, 1 insertion(+)
>>>
>>> I can confirm that this is indeed the same person.
>>
>> What would be more of interest is why we'd be interested in this patch
>> as there is no commit/patch sent by Brandon with this email in gits history.
>
> Once I "git am" the message that began this thread, there will be a
> commit under this new ident, so that would be somewhat a moot point.
"Get to the top of 'git shortlog -sn' with this one easy trick" :)
(The patch makes sense, good to see you back on-list Brandon)

← back to recent threads