Re: [PATCH] mailmap: update brandon williams's email address

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 8, 2018, 06:08 UTC
Message-ID: <xmqq5zw48s9q.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAGZ79kYrgpZDqAhg8c11V_qJTCzzw4-qrVN2z_Y_OAeCbWU6dQ@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 13 quoted lines

> On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
>>
>> Brandon Williams wrote:
>>
>> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com>
>> > ---
>> >  .mailmap | 1 +
>> >  1 file changed, 1 insertion(+)
>>
>> I can confirm that this is indeed the same person.
>
> What would be more of interest is why we'd be interested in this patch
> as there is no commit/patch sent by Brandon with this email in gits history.

Once I "git am" the message that began this thread, there will be a commit under this new ident, so that would be somewhat a moot point.

If this were "Jonathan asked Brandon if we want to record an address we can reach him in our .mailmap file and sent a patch to add one", then the story is different, and I tend to agree with you that such a patch is more or less pointless. That's not the purpose of the mailmap file.

Not until git-send-email learns to use that file to rewrite To/cc/etc to the "canonical" addresses, anyway ;-)

I am not sure if there are people whose "canonical" address to be used as the author is not necessarily the best address they want to get their e-mails at, though. If we can be reasonably sure that the set of such people is empty, then people can take the above mention about send-email as a hint about a low-hanging fruit ;-)

Thanks.