{"thread":{"id":"49971","subject":"[PATCH] mailmap: update brandon williams's email address","startedAt":"2018-12-07T20:56:30Z","lastAt":"2019-01-18T18:38:18Z","messageCount":12,"participants":["Brandon Williams","Jonathan Nieder","Stefan Beller","Junio C Hamano","Duy Nguyen","Ævar Arnfjörð Bjarmason","Johannes Schindelin","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"364753","messageId":"20181207205621.49961-1-bwilliams.eng@gmail.com","threadId":"49971","inReplyTo":null,"subject":"[PATCH] mailmap: update brandon williams's email address","fromName":"Brandon Williams","fromEmail":"bwilliamseng@gmail.com","sentAt":"2018-12-07T20:56:21Z","receivedAt":"2018-12-07T20:56:30Z","isPatch":true,"sender":{"key":"bwilliamseng@gmail.com","avatar":null},"body":"Signed-off-by: Brandon Williams \n---\n .mailmap | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/.mailmap b/.mailmap\nindex eb7b5fc7b..247a3deb7 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -27,6 +27,7 @@ Ben Walton \n Benoit Sigoure \n Bernt Hansen \n Brandon Casey \n+Brandon Williams \n brian m. carlson \n brian m. carlson \n Bryan Larsen \n-- \n2.19.1\n\n"},{"id":"364754","messageId":"20181207214013.GA73340@google.com","threadId":"49971","inReplyTo":"20181207205621.49961-1-bwilliams.eng@gmail.com","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-12-07T21:40:13Z","receivedAt":"2018-12-07T21:40:18Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Brandon Williams wrote:\n\n> Signed-off-by: Brandon Williams \n> ---\n> .mailmap | 1 +\n> 1 file changed, 1 insertion(+)\n\nI can confirm that this is indeed the same person.\n\nReviewed-by: Jonathan Nieder \n\nWelcome back!\n"},{"id":"364760","messageId":"CAGZ79kYrgpZDqAhg8c11V_qJTCzzw4-qrVN2z_Y_OAeCbWU6dQ@mail.gmail.com","threadId":"49971","inReplyTo":"20181207214013.GA73340@google.com","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-12-07T22:11:18Z","receivedAt":"2018-12-07T22:11:33Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder wrote:\n>\n> Brandon Williams wrote:\n>\n> > Signed-off-by: Brandon Williams \n> > ---\n> > .mailmap | 1 +\n> > 1 file changed, 1 insertion(+)\n>\n> I can confirm that this is indeed the same person.\n\nWhat would be more of interest is why we'd be interested in this patch\nas there is no commit/patch sent by Brandon with this email in gits history.\n\nIs that so you get cc'd on your private address and can follow\nthings you worked on without being subscribed to the mailing list?\n(I'd be interested to see the use case in the commit message;)\n\nThanks,\nStefan\n"},{"id":"364763","messageId":"20181207222225.GC73340@google.com","threadId":"49971","inReplyTo":"CAGZ79kYrgpZDqAhg8c11V_qJTCzzw4-qrVN2z_Y_OAeCbWU6dQ@mail.gmail.com","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-12-07T22:22:25Z","receivedAt":"2018-12-07T22:22:30Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nStefan Beller wrote:\n\n> What would be more of interest is why we'd be interested in this patch\n> as there is no commit/patch sent by Brandon with this email in gits history.\n\nI think there's an implicit assumption in this question that isn't\nspelled out. Do I understand correctly that you're saying the main\npurpose of .mailmap is to figure out whether two commits are by the\nsame author?\n\nMy own uses of .mailmap primarily have a different purpose: to find\nout the preferred contact address for the author of a given commit.\n\nThanks,\nJonathan\n"},{"id":"364791","messageId":"xmqq5zw48s9q.fsf@gitster-ct.c.googlers.com","threadId":"49971","inReplyTo":"CAGZ79kYrgpZDqAhg8c11V_qJTCzzw4-qrVN2z_Y_OAeCbWU6dQ@mail.gmail.com","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-12-08T06:08:33Z","receivedAt":"2018-12-08T06:08:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stefan Beller writes:\n\n> On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder wrote:\n>>\n>> Brandon Williams wrote:\n>>\n>> > Signed-off-by: Brandon Williams \n>> > ---\n>> > .mailmap | 1 +\n>> > 1 file changed, 1 insertion(+)\n>>\n>> I can confirm that this is indeed the same person.\n>\n> What would be more of interest is why we'd be interested in this patch\n> as there is no commit/patch sent by Brandon with this email in gits history.\n\nOnce I \"git am\" the message that began this thread, there will be a\ncommit under this new ident, so that would be somewhat a moot point.\n\nIf this were \"Jonathan asked Brandon if we want to record an address\nwe can reach him in our .mailmap file and sent a patch to add one\",\nthen the story is different, and I tend to agree with you that such\na patch is more or less pointless. That's not the purpose of the\nmailmap file.\n\nNot until git-send-email learns to use that file to rewrite\nTo/cc/etc to the \"canonical\" addresses, anyway ;-)\n\nI am not sure if there are people whose \"canonical\" address to be\nused as the author is not necessarily the best address they want to\nget their e-mails at, though. If we can be reasonably sure that the\nset of such people is empty, then people can take the above mention\nabout send-email as a hint about a low-hanging fruit ;-)\n\nThanks.\n\n\n"},{"id":"364794","messageId":"CALN-EhSQZiOsXwOyDJo_muTcP9HsifmqyD1oLxMunv5CfAdHgg@mail.gmail.com","threadId":"49971","inReplyTo":"xmqq5zw48s9q.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Brandon Williams","fromEmail":"bwilliamseng@gmail.com","sentAt":"2018-12-08T06:51:57Z","receivedAt":"2018-12-08T06:52:12Z","isPatch":true,"sender":{"key":"bwilliamseng@gmail.com","avatar":null},"body":"On Fri, Dec 7, 2018 at 10:08 PM Junio C Hamano wrote:\n>\n> Stefan Beller writes:\n>\n> > On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder wrote:\n> >>\n> >> Brandon Williams wrote:\n> >>\n> >> > Signed-off-by: Brandon Williams \n> >> > ---\n> >> > .mailmap | 1 +\n> >> > 1 file changed, 1 insertion(+)\n> >>\n> >> I can confirm that this is indeed the same person.\n> >\n> > What would be more of interest is why we'd be interested in this patch\n> > as there is no commit/patch sent by Brandon with this email in gits history.\n>\n> Once I \"git am\" the message that began this thread, there will be a\n> commit under this new ident, so that would be somewhat a moot point.\n>\n> If this were \"Jonathan asked Brandon if we want to record an address\n> we can reach him in our .mailmap file and sent a patch to add one\",\n> then the story is different, and I tend to agree with you that such\n> a patch is more or less pointless. That's not the purpose of the\n> mailmap file.\n>\n\nTurns out this is exactly the reason :) I've had a couple of people\nreach out to me asking me to do this because CCing my old email\nbounces and they've wanted my input/comments on something related to\nwork I've done. If that's not the intended purpose then please ignore\nthis patch\n\n> Not until git-send-email learns to use that file to rewrite\n> To/cc/etc to the \"canonical\" addresses, anyway ;-)\n>\n> I am not sure if there are people whose \"canonical\" address to be\n> used as the author is not necessarily the best address they want to\n> get their e-mails at, though. If we can be reasonably sure that the\n> set of such people is empty, then people can take the above mention\n> about send-email as a hint about a low-hanging fruit ;-)\n>\n> Thanks.\n>\n>\n"},{"id":"364799","messageId":"CACsJy8D82Geu_qyeJy6Bt18GtQweV-_7oAr9HJVY81BEAxwWNA@mail.gmail.com","threadId":"49971","inReplyTo":"xmqq5zw48s9q.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-12-08T08:25:04Z","receivedAt":"2018-12-08T08:25:34Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Sat, Dec 8, 2018 at 7:09 AM Junio C Hamano wrote:\n> If this were \"Jonathan asked Brandon if we want to record an address\n> we can reach him in our .mailmap file and sent a patch to add one\",\n\nNot sure about Jonathan, but I did.\n\n> then the story is different, and I tend to agree with you that such\n> a patch is more or less pointless. That's not the purpose of the\n> mailmap file.\n\nNot directly, but when multiple commands use mailmap to show the\ncanonical mail addresses, then it kinda is. When I look back at an old\ncommit message, I may look up the author name and address, which is\nmapped.\n\n> Not until git-send-email learns to use that file to rewrite\n> To/cc/etc to the \"canonical\" addresses, anyway ;-)\n\ngit-send-email does not have to when I copy/paste the address from\ngit-log anyway.\n\n> I am not sure if there are people whose \"canonical\" address to be\n> used as the author is not necessarily the best address they want to\n> get their e-mails at, though. If we can be reasonably sure that the\n> set of such people is empty, then people can take the above mention\n> about send-email as a hint about a low-hanging fruit ;-)\n>\n> Thanks.\n>\n>\n\n\n-- \nDuy\n"},{"id":"364800","messageId":"87sgz8xlcr.fsf@evledraar.gmail.com","threadId":"49971","inReplyTo":"xmqq5zw48s9q.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-12-08T12:18:44Z","receivedAt":"2018-12-08T12:18:52Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Sat, Dec 08 2018, Junio C Hamano wrote:\n\n> Stefan Beller writes:\n>\n>> On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder wrote:\n>>>\n>>> Brandon Williams wrote:\n>>>\n>>> > Signed-off-by: Brandon Williams \n>>> > ---\n>>> > .mailmap | 1 +\n>>> > 1 file changed, 1 insertion(+)\n>>>\n>>> I can confirm that this is indeed the same person.\n>>\n>> What would be more of interest is why we'd be interested in this patch\n>> as there is no commit/patch sent by Brandon with this email in gits history.\n>\n> Once I \"git am\" the message that began this thread, there will be a\n> commit under this new ident, so that would be somewhat a moot point.\n\n\"Get to the top of 'git shortlog -sn' with this one easy trick\" :)\n\n(The patch makes sense, good to see you back on-list Brandon)\n"},{"id":"364910","messageId":"nycvar.QRO.7.76.6.1812100934330.43@tvgsbejvaqbjf.bet","threadId":"49971","inReplyTo":"CALN-EhSQZiOsXwOyDJo_muTcP9HsifmqyD1oLxMunv5CfAdHgg@mail.gmail.com","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-12-10T08:36:34Z","receivedAt":"2018-12-10T08:36:40Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 7 Dec 2018, Brandon Williams wrote:\n\n> On Fri, Dec 7, 2018 at 10:08 PM Junio C Hamano \n> wrote:\n> >\n> > Stefan Beller writes:\n> >\n> > > On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder \n> > > wrote:\n> > >>\n> > >> Brandon Williams wrote:\n> > >>\n> > >> > Signed-off-by: Brandon Williams \n> > >> > ---\n> > >> > .mailmap | 1 +\n> > >> > 1 file changed, 1 insertion(+)\n> > >>\n> > >> I can confirm that this is indeed the same person.\n> > >\n> > > What would be more of interest is why we'd be interested in this\n> > > patch as there is no commit/patch sent by Brandon with this email in\n> > > gits history.\n> >\n> > Once I \"git am\" the message that began this thread, there will be a\n> > commit under this new ident, so that would be somewhat a moot point.\n> >\n> > If this were \"Jonathan asked Brandon if we want to record an address\n> > we can reach him in our .mailmap file and sent a patch to add one\",\n> > then the story is different, and I tend to agree with you that such a\n> > patch is more or less pointless. That's not the purpose of the\n> > mailmap file.\n> >\n> \n> Turns out this is exactly the reason :) I've had a couple of people\n> reach out to me asking me to do this because CCing my old email bounces\n> and they've wanted my input/comments on something related to work I've\n> done. If that's not the intended purpose then please ignore this patch\n\nUnless we come up with a better way to indicate the current address of a\nGit contributor (I seem to remember that David Turner used the same\napproach after leaving Twitter so that people could Cc: him with the\ncorrect address), I suggest that we keep using .mailmap for that purpose.\n\nThanks,\nDscho\n"},{"id":"367109","messageId":"20190118165754.GA11350@sigill.intra.peff.net","threadId":"49971","inReplyTo":"20181207222225.GC73340@google.com","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-01-18T16:57:54Z","receivedAt":"2019-01-18T16:57:57Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Dec 07, 2018 at 02:22:25PM -0800, Jonathan Nieder wrote:\n\n> Stefan Beller wrote:\n> \n> > What would be more of interest is why we'd be interested in this patch\n> > as there is no commit/patch sent by Brandon with this email in gits history.\n> \n> I think there's an implicit assumption in this question that isn't\n> spelled out. Do I understand correctly that you're saying the main\n> purpose of .mailmap is to figure out whether two commits are by the\n> same author?\n> \n> My own uses of .mailmap primarily have a different purpose: to find\n> out the preferred contact address for the author of a given commit.\n\nI just had to cc Brandon and manually look up his email address, which\nmade me wonder what ever happened to this patch. :)\n\nFWIW, I also use mailmap to find contact email addresses, with:\n\n $ git help who\n 'who' is aliased to '!sh -c 'git --no-pager log -1 --format=\"%an <%aE>\" --author=\"$1\" -i' -'\n\nSo lacking another such registry, I'd like to add my support for using\nmailmap for this purpose.\n\n-Peff\n"},{"id":"367124","messageId":"xmqqa7jxltku.fsf@gitster-ct.c.googlers.com","threadId":"49971","inReplyTo":"20190118165754.GA11350@sigill.intra.peff.net","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-01-18T18:16:33Z","receivedAt":"2019-01-18T18:16:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> I just had to cc Brandon and manually look up his email address, which\n> made me wonder what ever happened to this patch. :)\n\nd076ad13 (\"Merge branch 'bw/mailmap'\", 2019-01-14)\n\n"},{"id":"367126","messageId":"20190118183814.GA9591@sigill.intra.peff.net","threadId":"49971","inReplyTo":"xmqqa7jxltku.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] mailmap: update brandon williams's email address","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-01-18T18:38:14Z","receivedAt":"2019-01-18T18:38:18Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jan 18, 2019 at 10:16:33AM -0800, Junio C Hamano wrote:\n\n> Jeff King writes:\n> \n> > I just had to cc Brandon and manually look up his email address, which\n> > made me wonder what ever happened to this patch. :)\n> \n> d076ad13 (\"Merge branch 'bw/mailmap'\", 2019-01-14)\n\nOh, heh. False alarm: I was looking up his address after bisecting back\nto a failure from last year. And my \"who\" alias walks from the current\nHEAD. It should probably choose a known-current point like\n\"origin/master\".\n\nSorry for the noise!\n\n-Peff\n"}]}