threads / patch / 4993

patchgitweb: fix two warnings

Subject: [PATCH] gitweb: fix two warnings

## tl;dr

3 messages between Jul 26, 2006 and Jul 26, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Johannes Schindelin· Jul 26, 2006, 14:58 UTC · lore

These warnings cluttered up my log.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
 gitweb/gitweb.cgi |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to gitweb/gitweb.cgi +2 −2

diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi
index e226ac2..e5fca63 100755
--- a/gitweb/gitweb.cgi
+++ b/gitweb/gitweb.cgi
@@ -795,7 +795,7 @@ sub git_read_projects {
 	if (-d $projects_list) {
 		# search in directory
 		my $dir = $projects_list;
-		opendir my $dh, $dir or return undef;
+		opendir my ($dh), $dir or return undef;
 		while (my $dir = readdir($dh)) {
 			if (-e "$projectroot/$dir/HEAD") {
 				my $pr = {
@@ -810,7 +810,7 @@ sub git_read_projects {
 		# 'git%2Fgit.git Linus+Torvalds'
 		# 'libs%2Fklibc%2Fklibc.git H.+Peter+Anvin'
 		# 'linux%2Fhotplug%2Fudev.git Greg+Kroah-Hartman'
-		open my $fd , $projects_list or return undef;
+		open my ($fd), $projects_list or return undef;
 		while (my $line = <$fd>) {
 			chomp $line;
 			my ($path, $owner) = split ' ', $line;

-- 
1.4.2.rc2.g6a4e

Luben Tuikov· Jul 26, 2006, 17:48 UTC · re: Johannes Schindelin · lore

Re: [PATCH] gitweb: fix two warnings

--- Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 32 quoted lines

> 
> These warnings cluttered up my log.
> 
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
>  gitweb/gitweb.cgi |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi
> index e226ac2..e5fca63 100755
> --- a/gitweb/gitweb.cgi
> +++ b/gitweb/gitweb.cgi
> @@ -795,7 +795,7 @@ sub git_read_projects {
>  	if (-d $projects_list) {
>  		# search in directory
>  		my $dir = $projects_list;
> -		opendir my $dh, $dir or return undef;
> +		opendir my ($dh), $dir or return undef;
>  		while (my $dir = readdir($dh)) {
>  			if (-e "$projectroot/$dir/HEAD") {
>  				my $pr = {
> @@ -810,7 +810,7 @@ sub git_read_projects {
>  		# 'git%2Fgit.git Linus+Torvalds'
>  		# 'libs%2Fklibc%2Fklibc.git H.+Peter+Anvin'
>  		# 'linux%2Fhotplug%2Fudev.git Greg+Kroah-Hartman'
> -		open my $fd , $projects_list or return undef;
> +		open my ($fd), $projects_list or return undef;
>  		while (my $line = <$fd>) {
>  			chomp $line;
>  			my ($path, $owner) = split ' ', $line;
> -- 
> 1.4.2.rc2.g6a4e

Can you please give more details of the warnings, cut-and-paste would be nice, the problem as you perceive it, and your solution to it?

Thanks,
   Luben

Johannes Schindelin· Jul 26, 2006, 18:43 UTC · re: Luben Tuikov · lore

Re: [PATCH] gitweb: fix two warnings

Hi,

On Wed, 26 Jul 2006, Luben Tuikov wrote:

Show 6 quoted lines

> --- Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > 
> > These warnings cluttered up my log.
> 
> Can you please give more details of the warnings, cut-and-paste
> would be nice, the problem as you perceive it, and your solution to it?

Sure: The log contains these lines over and over again (I wrapped them 
manually):

Wed Jul 26 15:54:52 2006] [error] [client 192.168.0.67] \ [Wed Jul 26 15:54:52 2006] \ gitweb.cgi: Parentheses missing around "my" list at \ /[my-private-repo]/.git/gitweb/gitweb.cgi line 798., \ referer: http://dumbo:1234/?p=.git;a=summary

and

[Wed Jul 26 15:54:52 2006] [error] [client 192.168.0.67] \ [Wed Jul 26 15:54:52 2006] \ gitweb.cgi: Parentheses missing around "my" list at \ /[my-private-repo]/.git/gitweb/gitweb.cgi line 813., \ referer: http://dumbo:1234/?p=.git;a=summary

And my solution was to add the parentheses around the parameter of "my".

Ciao, Dscho