{"thread":{"id":"4993","subject":"[PATCH] gitweb: fix two warnings","startedAt":"2006-07-26T14:58:35Z","lastAt":"2006-07-26T18:43:56Z","messageCount":3,"participants":["Johannes Schindelin","Luben Tuikov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"24135","messageId":"Pine.LNX.4.63.0607261658130.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4993","inReplyTo":null,"subject":"[PATCH] gitweb: fix two warnings","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-26T14:58:35Z","receivedAt":"2006-07-26T14:58:35Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nThese warnings cluttered up my log.\n\nSigned-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n---\n gitweb/gitweb.cgi |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi\nindex e226ac2..e5fca63 100755\n--- a/gitweb/gitweb.cgi\n+++ b/gitweb/gitweb.cgi\n@@ -795,7 +795,7 @@ sub git_read_projects {\n \tif (-d $projects_list) {\n \t\t# search in directory\n \t\tmy $dir = $projects_list;\n-\t\topendir my $dh, $dir or return undef;\n+\t\topendir my ($dh), $dir or return undef;\n \t\twhile (my $dir = readdir($dh)) {\n \t\t\tif (-e \"$projectroot/$dir/HEAD\") {\n \t\t\t\tmy $pr = {\n@@ -810,7 +810,7 @@ sub git_read_projects {\n \t\t# 'git%2Fgit.git Linus+Torvalds'\n \t\t# 'libs%2Fklibc%2Fklibc.git H.+Peter+Anvin'\n \t\t# 'linux%2Fhotplug%2Fudev.git Greg+Kroah-Hartman'\n-\t\topen my $fd , $projects_list or return undef;\n+\t\topen my ($fd), $projects_list or return undef;\n \t\twhile (my $line = <$fd>) {\n \t\t\tchomp $line;\n \t\t\tmy ($path, $owner) = split ' ', $line;\n-- \n1.4.2.rc2.g6a4e\n"},{"id":"24144","messageId":"20060726174841.90834.qmail@web31809.mail.mud.yahoo.com","threadId":"4993","inReplyTo":"Pine.LNX.4.63.0607261658130.29667@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] gitweb: fix two warnings","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-07-26T17:48:41Z","receivedAt":"2006-07-26T17:48:41Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:\n> \n> These warnings cluttered up my log.\n> \n> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n> ---\n>  gitweb/gitweb.cgi |    4 ++--\n>  1 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi\n> index e226ac2..e5fca63 100755\n> --- a/gitweb/gitweb.cgi\n> +++ b/gitweb/gitweb.cgi\n> @@ -795,7 +795,7 @@ sub git_read_projects {\n>  \tif (-d $projects_list) {\n>  \t\t# search in directory\n>  \t\tmy $dir = $projects_list;\n> -\t\topendir my $dh, $dir or return undef;\n> +\t\topendir my ($dh), $dir or return undef;\n>  \t\twhile (my $dir = readdir($dh)) {\n>  \t\t\tif (-e \"$projectroot/$dir/HEAD\") {\n>  \t\t\t\tmy $pr = {\n> @@ -810,7 +810,7 @@ sub git_read_projects {\n>  \t\t# 'git%2Fgit.git Linus+Torvalds'\n>  \t\t# 'libs%2Fklibc%2Fklibc.git H.+Peter+Anvin'\n>  \t\t# 'linux%2Fhotplug%2Fudev.git Greg+Kroah-Hartman'\n> -\t\topen my $fd , $projects_list or return undef;\n> +\t\topen my ($fd), $projects_list or return undef;\n>  \t\twhile (my $line = <$fd>) {\n>  \t\t\tchomp $line;\n>  \t\t\tmy ($path, $owner) = split ' ', $line;\n> -- \n> 1.4.2.rc2.g6a4e\n\nCan you please give more details of the warnings, cut-and-paste\nwould be nice, the problem as you perceive it, and your solution to it?\n\nThanks,\n   Luben\n"},{"id":"24151","messageId":"Pine.LNX.4.63.0607262040270.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4993","inReplyTo":"20060726174841.90834.qmail@web31809.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: fix two warnings","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-26T18:43:56Z","receivedAt":"2006-07-26T18:43:56Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 26 Jul 2006, Luben Tuikov wrote:\n\n> --- Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:\n> > \n> > These warnings cluttered up my log.\n> \n> Can you please give more details of the warnings, cut-and-paste\n> would be nice, the problem as you perceive it, and your solution to it?\n\nSure: The log contains these lines over and over again (I wrapped them \nmanually):\n\nWed Jul 26 15:54:52 2006] [error] [client 192.168.0.67] \\\n[Wed Jul 26 15:54:52 2006] \\\ngitweb.cgi: Parentheses missing around \"my\" list at \\\n/[my-private-repo]/.git/gitweb/gitweb.cgi line 798., \\\nreferer: http://dumbo:1234/?p=.git;a=summary\n\nand\n\n[Wed Jul 26 15:54:52 2006] [error] [client 192.168.0.67] \\\n[Wed Jul 26 15:54:52 2006] \\\ngitweb.cgi: Parentheses missing around \"my\" list at \\\n/[my-private-repo]/.git/gitweb/gitweb.cgi line 813., \\\nreferer: http://dumbo:1234/?p=.git;a=summary\n\nAnd my solution was to add the parentheses around the parameter of \"my\".\n\nCiao,\nDscho\n"}]}