Re: [PATCH] gitweb: fix two warnings
- From
- Luben Tuikov <ltuikov@yahoo.com>
- Date
- Jul 26, 2006, 17:48 UTC
- Message-ID
- <20060726174841.90834.qmail@web31809.mail.mud.yahoo.com>
- In-Reply-To
- <Pine.LNX.4.63.0607261658130.29667@wbgn013.biozentrum.uni-wuerzburg.de>
--- Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 32 quoted lines
>
> These warnings cluttered up my log.
>
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
> gitweb/gitweb.cgi | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi
> index e226ac2..e5fca63 100755
> --- a/gitweb/gitweb.cgi
> +++ b/gitweb/gitweb.cgi
> @@ -795,7 +795,7 @@ sub git_read_projects {
> if (-d $projects_list) {
> # search in directory
> my $dir = $projects_list;
> - opendir my $dh, $dir or return undef;
> + opendir my ($dh), $dir or return undef;
> while (my $dir = readdir($dh)) {
> if (-e "$projectroot/$dir/HEAD") {
> my $pr = {
> @@ -810,7 +810,7 @@ sub git_read_projects {
> # 'git%2Fgit.git Linus+Torvalds'
> # 'libs%2Fklibc%2Fklibc.git H.+Peter+Anvin'
> # 'linux%2Fhotplug%2Fudev.git Greg+Kroah-Hartman'
> - open my $fd , $projects_list or return undef;
> + open my ($fd), $projects_list or return undef;
> while (my $line = <$fd>) {
> chomp $line;
> my ($path, $owner) = split ' ', $line;
> --
> 1.4.2.rc2.g6a4eCan you please give more details of the warnings, cut-and-paste would be nice, the problem as you perceive it, and your solution to it?
Thanks, Luben