threads / patch / 49837

patchINSTALL: add macOS gettext and sdk header explanation to INSTALL

Subject: [PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL

## tl;dr

3 messages between Nov 15, 2018 and Nov 15, 2018. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

yanke131415@gmail.com· Nov 15, 2018, 01:32 UTC · lore

From: out0fmemory <jiu4majia2@163.com>

---
 INSTALL | 7 +++++++
 1 file changed, 7 insertions(+)

Show changes to INSTALL +7 −0

diff --git a/INSTALL b/INSTALL
index c39006e8e7..b7bfb53c12 100644
--- a/INSTALL
+++ b/INSTALL
@@ -165,6 +165,9 @@ Issues of note:
 	  use English. Under autoconf the configure script will do this
 	  automatically if it can't find libintl on the system.
 
+    In macOS, can install and link gettext with brew as "brew install gettext"
+    and "brew link --force gettext", the link operation is necessary.
+
 	- Python version 2.4 or later (but not 3.x, which is not
 	  supported by Perforce) is needed to use the git-p4 interface
 	  to Perforce.
@@ -178,6 +181,10 @@ Issues of note:
    will include them.  Note that config.mak is not distributed;
    the name is reserved for local settings.
 
+  - In macOs 10.14, the Command Line Tool not contains the headers as before, so it
+    need install Command Line Tool 10.14 and install the headers which command
+    "sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target".
+
  - To build and install documentation suite, you need to have
    the asciidoc/xmlto toolchain.  Because not many people are
    inclined to install the tools, the default build target

-- 
2.19.1.1052.gd166e6afe5

Jonathan Nieder· Nov 15, 2018, 03:05 UTC · re: yanke131415@gmail.com · lore

Re: [PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL

Hi!

yanke131415@gmail.com wrote:

Show 5 quoted lines

> From: out0fmemory <jiu4majia2@163.com>
> 
> ---
>  INSTALL | 7 +++++++
>  1 file changed, 7 insertions(+)

Thanks for writing. A few bits of administrivia, from https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html:

Can we forge your sign-off? See the section "certify your work" in SubmittingPatches for what this means.

What name should we attribute this change to? Documentation/SubmittingPatches explains:

 Also notice that a real name is used in the Signed-off-by: line.
 Please don’t hide your real name.

[...]

Show 9 quoted lines

> --- a/INSTALL
> +++ b/INSTALL
> @@ -165,6 +165,9 @@ Issues of note:
>  	  use English. Under autoconf the configure script will do this
>  	  automatically if it can't find libintl on the system.
>  
> +    In macOS, can install and link gettext with brew as "brew install gettext"
> +    and "brew link --force gettext", the link operation is necessary.
> +

As context (e.g. to go in the commit message), can you tell us more about this? E.g. what happens if you don't perform the link operation?

[...]

Show 8 quoted lines

> @@ -178,6 +181,10 @@ Issues of note:
>     will include them.  Note that config.mak is not distributed;
>     the name is reserved for local settings.
>  
> +  - In macOs 10.14, the Command Line Tool not contains the headers as before, so it
> +    need install Command Line Tool 10.14 and install the headers which command
> +    "sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target".
> +

Likewise: what is the symptom if this isn't done?

Is there more general advice we can put here that will survive past macOS 10.14?

Thanks and hope that helps, Jonathan

yan ke· Nov 15, 2018, 10:42 UTC · re: Jonathan Nieder · lore

Re: [PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL

Thanks for review, I will summit a new patch soon to improve this.

Jonathan Nieder <jrnieder@gmail.com> 于2018年11月15日周四 上午11:05写道：

Show 55 quoted lines

>
> Hi!
>
> yanke131415@gmail.com wrote:
>
> > From: out0fmemory <jiu4majia2@163.com>
> >
> > ---
> >  INSTALL | 7 +++++++
> >  1 file changed, 7 insertions(+)
>
> Thanks for writing.  A few bits of administrivia, from
> https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html:
>
> Can we forge your sign-off?  See the section "certify your work" in
> SubmittingPatches for what this means.
>
> What name should we attribute this change to?  Documentation/SubmittingPatches
> explains:
>
>  Also notice that a real name is used in the Signed-off-by: line.
>  Please don’t hide your real name.
>
> [...]
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -165,6 +165,9 @@ Issues of note:
> >         use English. Under autoconf the configure script will do this
> >         automatically if it can't find libintl on the system.
> >
> > +    In macOS, can install and link gettext with brew as "brew install gettext"
> > +    and "brew link --force gettext", the link operation is necessary.
> > +
>
> As context (e.g. to go in the commit message), can you tell us more
> about this?  E.g. what happens if you don't perform the link
> operation?
>
> [...]
> > @@ -178,6 +181,10 @@ Issues of note:
> >     will include them.  Note that config.mak is not distributed;
> >     the name is reserved for local settings.
> >
> > +  - In macOs 10.14, the Command Line Tool not contains the headers as before, so it
> > +    need install Command Line Tool 10.14 and install the headers which command
> > +    "sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target".
> > +
>
> Likewise: what is the symptom if this isn't done?
>
> Is there more general advice we can put here that will survive past
> macOS 10.14?
>
> Thanks and hope that helps,
> Jonathan