# [PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL 3 messages from 2018-11-15 to 2018-11-15. Participants: yanke131415@gmail.com, Jonathan Nieder, yan ke. Thread: https://gitlist.dev/t/49837 ## yanke131415@gmail.com, 2018-11-15 01:32 Subject: [PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL Message-ID: <20181115013233.24685-1-yanke131415@gmail.com> URL: https://gitlist.dev/e/20181115013233.24685-1-yanke131415%40gmail.com ``` From: out0fmemory --- INSTALL | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/INSTALL b/INSTALL index c39006e8e7..b7bfb53c12 100644 --- a/INSTALL +++ b/INSTALL @@ -165,6 +165,9 @@ Issues of note: use English. Under autoconf the configure script will do this automatically if it can't find libintl on the system. + In macOS, can install and link gettext with brew as "brew install gettext" + and "brew link --force gettext", the link operation is necessary. + - Python version 2.4 or later (but not 3.x, which is not supported by Perforce) is needed to use the git-p4 interface to Perforce. @@ -178,6 +181,10 @@ Issues of note: will include them. Note that config.mak is not distributed; the name is reserved for local settings. + - In macOs 10.14, the Command Line Tool not contains the headers as before, so it + need install Command Line Tool 10.14 and install the headers which command + "sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target". + - To build and install documentation suite, you need to have the asciidoc/xmlto toolchain. Because not many people are inclined to install the tools, the default build target -- 2.19.1.1052.gd166e6afe5 ``` ## Jonathan Nieder, 2018-11-15 03:05 Subject: Re: [PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL Message-ID: <20181115030503.GC92137@google.com> URL: https://gitlist.dev/e/20181115030503.GC92137%40google.com In-Reply-To: <20181115013233.24685-1-yanke131415@gmail.com> ``` Hi! yanke131415@gmail.com wrote: > From: out0fmemory > > --- > INSTALL | 7 +++++++ > 1 file changed, 7 insertions(+) Thanks for writing. A few bits of administrivia, from https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html: Can we forge your sign-off? See the section "certify your work" in SubmittingPatches for what this means. What name should we attribute this change to? Documentation/SubmittingPatches explains: Also notice that a real name is used in the Signed-off-by: line. Please don’t hide your real name. [...] > --- a/INSTALL > +++ b/INSTALL > @@ -165,6 +165,9 @@ Issues of note: > use English. Under autoconf the configure script will do this > automatically if it can't find libintl on the system. > > + In macOS, can install and link gettext with brew as "brew install gettext" > + and "brew link --force gettext", the link operation is necessary. > + As context (e.g. to go in the commit message), can you tell us more about this? E.g. what happens if you don't perform the link operation? [...] > @@ -178,6 +181,10 @@ Issues of note: > will include them. Note that config.mak is not distributed; > the name is reserved for local settings. > > + - In macOs 10.14, the Command Line Tool not contains the headers as before, so it > + need install Command Line Tool 10.14 and install the headers which command > + "sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target". > + Likewise: what is the symptom if this isn't done? Is there more general advice we can put here that will survive past macOS 10.14? Thanks and hope that helps, Jonathan ``` ## yan ke, 2018-11-15 10:42 Subject: Re: [PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL Message-ID: URL: https://gitlist.dev/e/CAJosSJ757tVMy3XL_CEwhs0w-meZR7bv8b66V_%2B_BcnXRcALiA%40mail.gmail.com In-Reply-To: <20181115030503.GC92137@google.com> ``` Thanks for review, I will summit a new patch soon to improve this. Jonathan Nieder 于2018年11月15日周四 上午11:05写道： > > Hi! > > yanke131415@gmail.com wrote: > > > From: out0fmemory > > > > --- > > INSTALL | 7 +++++++ > > 1 file changed, 7 insertions(+) > > Thanks for writing. A few bits of administrivia, from > https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html: > > Can we forge your sign-off? See the section "certify your work" in > SubmittingPatches for what this means. > > What name should we attribute this change to? Documentation/SubmittingPatches > explains: > > Also notice that a real name is used in the Signed-off-by: line. > Please don’t hide your real name. > > [...] > > --- a/INSTALL > > +++ b/INSTALL > > @@ -165,6 +165,9 @@ Issues of note: > > use English. Under autoconf the configure script will do this > > automatically if it can't find libintl on the system. > > > > + In macOS, can install and link gettext with brew as "brew install gettext" > > + and "brew link --force gettext", the link operation is necessary. > > + > > As context (e.g. to go in the commit message), can you tell us more > about this? E.g. what happens if you don't perform the link > operation? > > [...] > > @@ -178,6 +181,10 @@ Issues of note: > > will include them. Note that config.mak is not distributed; > > the name is reserved for local settings. > > > > + - In macOs 10.14, the Command Line Tool not contains the headers as before, so it > > + need install Command Line Tool 10.14 and install the headers which command > > + "sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target". > > + > > Likewise: what is the symptom if this isn't done? > > Is there more general advice we can put here that will survive past > macOS 10.14? > > Thanks and hope that helps, > Jonathan ```