{"thread":{"id":"49837","subject":"[PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL","startedAt":"2018-11-15T01:32:41Z","lastAt":"2018-11-15T10:42:28Z","messageCount":3,"participants":["yanke131415@gmail.com","Jonathan Nieder","yan ke"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"363410","messageId":"20181115013233.24685-1-yanke131415@gmail.com","threadId":"49837","inReplyTo":null,"subject":"[PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL","fromName":"","fromEmail":"yanke131415@gmail.com","sentAt":"2018-11-15T01:32:33Z","receivedAt":"2018-11-15T01:32:41Z","isPatch":true,"sender":{"key":"yanke131415@gmail.com","avatar":null},"body":"From: out0fmemory \n\n---\n INSTALL | 7 +++++++\n 1 file changed, 7 insertions(+)\n\ndiff --git a/INSTALL b/INSTALL\nindex c39006e8e7..b7bfb53c12 100644\n--- a/INSTALL\n+++ b/INSTALL\n@@ -165,6 +165,9 @@ Issues of note:\n \t use English. Under autoconf the configure script will do this\n \t automatically if it can't find libintl on the system.\n \n+ In macOS, can install and link gettext with brew as \"brew install gettext\"\n+ and \"brew link --force gettext\", the link operation is necessary.\n+\n \t- Python version 2.4 or later (but not 3.x, which is not\n \t supported by Perforce) is needed to use the git-p4 interface\n \t to Perforce.\n@@ -178,6 +181,10 @@ Issues of note:\n will include them. Note that config.mak is not distributed;\n the name is reserved for local settings.\n \n+ - In macOs 10.14, the Command Line Tool not contains the headers as before, so it\n+ need install Command Line Tool 10.14 and install the headers which command\n+ \"sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target\".\n+\n - To build and install documentation suite, you need to have\n the asciidoc/xmlto toolchain. Because not many people are\n inclined to install the tools, the default build target\n-- \n2.19.1.1052.gd166e6afe5\n\n"},{"id":"363411","messageId":"20181115030503.GC92137@google.com","threadId":"49837","inReplyTo":"20181115013233.24685-1-yanke131415@gmail.com","subject":"Re: [PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-11-15T03:05:03Z","receivedAt":"2018-11-15T03:05:09Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi!\n\nyanke131415@gmail.com wrote:\n\n> From: out0fmemory \n> \n> ---\n> INSTALL | 7 +++++++\n> 1 file changed, 7 insertions(+)\n\nThanks for writing. A few bits of administrivia, from\nhttps://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html:\n\nCan we forge your sign-off? See the section \"certify your work\" in\nSubmittingPatches for what this means.\n\nWhat name should we attribute this change to? Documentation/SubmittingPatches\nexplains:\n\n Also notice that a real name is used in the Signed-off-by: line.\n Please don’t hide your real name.\n\n[...]\n> --- a/INSTALL\n> +++ b/INSTALL\n> @@ -165,6 +165,9 @@ Issues of note:\n> \t use English. Under autoconf the configure script will do this\n> \t automatically if it can't find libintl on the system.\n> \n> + In macOS, can install and link gettext with brew as \"brew install gettext\"\n> + and \"brew link --force gettext\", the link operation is necessary.\n> +\n\nAs context (e.g. to go in the commit message), can you tell us more\nabout this? E.g. what happens if you don't perform the link\noperation?\n\n[...]\n> @@ -178,6 +181,10 @@ Issues of note:\n> will include them. Note that config.mak is not distributed;\n> the name is reserved for local settings.\n> \n> + - In macOs 10.14, the Command Line Tool not contains the headers as before, so it\n> + need install Command Line Tool 10.14 and install the headers which command\n> + \"sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target\".\n> +\n\nLikewise: what is the symptom if this isn't done?\n\nIs there more general advice we can put here that will survive past\nmacOS 10.14?\n\nThanks and hope that helps,\nJonathan\n"},{"id":"363419","messageId":"CAJosSJ757tVMy3XL_CEwhs0w-meZR7bv8b66V_+_BcnXRcALiA@mail.gmail.com","threadId":"49837","inReplyTo":"20181115030503.GC92137@google.com","subject":"Re: [PATCH] INSTALL: add macOS gettext and sdk header explanation to INSTALL","fromName":"yan ke","fromEmail":"yanke131415@gmail.com","sentAt":"2018-11-15T10:42:13Z","receivedAt":"2018-11-15T10:42:28Z","isPatch":true,"sender":{"key":"yanke131415@gmail.com","avatar":null},"body":"Thanks for review, I will summit a new patch soon to improve this.\n\nJonathan Nieder 于2018年11月15日周四 上午11:05写道：\n>\n> Hi!\n>\n> yanke131415@gmail.com wrote:\n>\n> > From: out0fmemory \n> >\n> > ---\n> > INSTALL | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n>\n> Thanks for writing. A few bits of administrivia, from\n> https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html:\n>\n> Can we forge your sign-off? See the section \"certify your work\" in\n> SubmittingPatches for what this means.\n>\n> What name should we attribute this change to? Documentation/SubmittingPatches\n> explains:\n>\n> Also notice that a real name is used in the Signed-off-by: line.\n> Please don’t hide your real name.\n>\n> [...]\n> > --- a/INSTALL\n> > +++ b/INSTALL\n> > @@ -165,6 +165,9 @@ Issues of note:\n> > use English. Under autoconf the configure script will do this\n> > automatically if it can't find libintl on the system.\n> >\n> > + In macOS, can install and link gettext with brew as \"brew install gettext\"\n> > + and \"brew link --force gettext\", the link operation is necessary.\n> > +\n>\n> As context (e.g. to go in the commit message), can you tell us more\n> about this? E.g. what happens if you don't perform the link\n> operation?\n>\n> [...]\n> > @@ -178,6 +181,10 @@ Issues of note:\n> > will include them. Note that config.mak is not distributed;\n> > the name is reserved for local settings.\n> >\n> > + - In macOs 10.14, the Command Line Tool not contains the headers as before, so it\n> > + need install Command Line Tool 10.14 and install the headers which command\n> > + \"sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target\".\n> > +\n>\n> Likewise: what is the symptom if this isn't done?\n>\n> Is there more general advice we can put here that will survive past\n> macOS 10.14?\n>\n> Thanks and hope that helps,\n> Jonathan\n"}]}