threads / patch / 49498

patchdocs: graph: Remove unnecessary `graph_update()' call

Subject: [PATCH] docs: graph: Remove unnecessary `graph_update()' call

## tl;dr

One message between Oct 6, 2018 and Oct 6, 2018. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Michael Witten· Oct 6, 2018, 04:28 UTC · lore

The sample code calls `get_revision()' followed by `graph_update()', but the documentation and source code indicate that `get_revision()' already calls `graph_update()' for you.

Signed-off-by: Michael Witten <mfwitten@gmail.com>
---
 Documentation/technical/api-history-graph.txt | 1 -
 1 file changed, 1 deletion(-)
Show changes to Documentation/technical/api-history-graph.txt +0 −1
diff --git a/Documentation/technical/api-history-graph.txt b/Documentation/technical/api-history-graph.txt
index 18142b6d29..d9fd98d435 100644
--- a/Documentation/technical/api-history-graph.txt
+++ b/Documentation/technical/api-history-graph.txt
@@ -115,7 +115,6 @@ struct commit *commit;
 struct git_graph *graph = graph_init(opts);
 
 while ((commit = get_revision(opts)) != NULL) {
-	graph_update(graph, commit);
 	while (!graph_is_commit_finished(graph))
 	{
 		struct strbuf sb;
-- 
2.18.0

← back to recent threads