git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] docs: graph: Remove unnecessary `graph_update()' call

From
Michael Witten <mfwitten@gmail.com>
Date
Oct 6, 2018, 04:28 UTC
Message-ID
<3dda7b8f75854716ac6b205ca05a7656-mfwitten@gmail.com>

The sample code calls `get_revision()' followed by `graph_update()', but the documentation and source code indicate that `get_revision()' already calls `graph_update()' for you.

Signed-off-by: Michael Witten <mfwitten@gmail.com>
---
 Documentation/technical/api-history-graph.txt | 1 -
 1 file changed, 1 deletion(-)
diff --git a/Documentation/technical/api-history-graph.txt b/Documentation/technical/api-history-graph.txt
index 18142b6d29..d9fd98d435 100644
--- a/Documentation/technical/api-history-graph.txt
+++ b/Documentation/technical/api-history-graph.txt
@@ -115,7 +115,6 @@ struct commit *commit;
 struct git_graph *graph = graph_init(opts);
 
 while ((commit = get_revision(opts)) != NULL) {
-	graph_update(graph, commit);
 	while (!graph_is_commit_finished(graph))
 	{
 		struct strbuf sb;
-- 
2.18.0
Message 1 of 1 in “docs: graph: Remove unnecessary `graph_update()' call”
  1. docs: graph: Remove unnecessary `graph_update()' callMichael Witten, Oct 6, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.