{"thread":{"id":"49498","subject":"[PATCH] docs: graph: Remove unnecessary `graph_update()' call","startedAt":"2018-10-06T04:28:42Z","lastAt":"2018-10-06T04:28:42Z","messageCount":1,"participants":["Michael Witten"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"359762","messageId":"3dda7b8f75854716ac6b205ca05a7656-mfwitten@gmail.com","threadId":"49498","inReplyTo":null,"subject":"[PATCH] docs: graph: Remove unnecessary `graph_update()' call","fromName":"Michael Witten","fromEmail":"mfwitten@gmail.com","sentAt":null,"receivedAt":"2018-10-06T04:28:42Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"The sample code calls `get_revision()' followed by `graph_update()',\nbut the documentation and source code indicate that `get_revision()'\nalready calls `graph_update()' for you.\n\nSigned-off-by: Michael Witten <mfwitten@gmail.com>\n---\n Documentation/technical/api-history-graph.txt | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/Documentation/technical/api-history-graph.txt b/Documentation/technical/api-history-graph.txt\nindex 18142b6d29..d9fd98d435 100644\n--- a/Documentation/technical/api-history-graph.txt\n+++ b/Documentation/technical/api-history-graph.txt\n@@ -115,7 +115,6 @@ struct commit *commit;\n struct git_graph *graph = graph_init(opts);\n \n while ((commit = get_revision(opts)) != NULL) {\n-\tgraph_update(graph, commit);\n \twhile (!graph_is_commit_finished(graph))\n \t{\n \t\tstruct strbuf sb;\n-- \n2.18.0\n\n"}]}