threads / patch / 49378

patchuserdiff.h: add missing declaration (hdr-check)

Subject: [PATCH] userdiff.h: add missing declaration (hdr-check)

## tl;dr

3 messages between Sep 19, 2018 and Sep 21, 2018. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Ramsay Jones· Sep 19, 2018, 00:20 UTC · lore
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,
... and this is the patch I needed for the current 'pu' branch.

ATB, Ramsay Jones

 userdiff.h | 2 ++
 1 file changed, 2 insertions(+)
Show changes to userdiff.h +2 −0
diff --git a/userdiff.h b/userdiff.h
index dad3fc03c1..b072bfe89a 100644
--- a/userdiff.h
+++ b/userdiff.h
@@ -3,6 +3,8 @@
 
 #include "notes-cache.h"
 
+struct index_state;
+
 struct userdiff_funcname {
 	const char *pattern;
 	int cflags;
-- 
2.19.0
Junio C Hamano· Sep 21, 2018, 16:24 UTC · re: Ramsay Jones · lore

Re: [PATCH] userdiff.h: add missing declaration (hdr-check)

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
Show 6 quoted lines
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Junio,
>
> ... and this is the patch I needed for the current 'pu' branch.

Which in turn means that this is to fix 5b338d60 ("userdiff.c: remove implicit dependency on the_index", 2018-09-15) and should be rolled into nd/the_index topic.

Show 20 quoted lines
>
> ATB,
> Ramsay Jones
>
>  userdiff.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/userdiff.h b/userdiff.h
> index dad3fc03c1..b072bfe89a 100644
> --- a/userdiff.h
> +++ b/userdiff.h
> @@ -3,6 +3,8 @@
>  
>  #include "notes-cache.h"
>  
> +struct index_state;
> +
>  struct userdiff_funcname {
>  	const char *pattern;
>  	int cflags;
Duy Nguyen· Sep 21, 2018, 16:26 UTC · re: Junio C Hamano · lore

Re: [PATCH] userdiff.h: add missing declaration (hdr-check)

On Fri, Sep 21, 2018 at 6:24 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
>
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
> > Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> > ---
> >
> > Hi Junio,
> >
> > ... and this is the patch I needed for the current 'pu' branch.
>
> Which in turn means that this is to fix 5b338d60 ("userdiff.c:
> remove implicit dependency on the_index", 2018-09-15) and should be
> rolled into nd/the_index topic.
I guess I should send v6 then?
-- 
Duy

← back to recent threads