{"thread":{"id":"49378","subject":"[PATCH] userdiff.h: add missing declaration (hdr-check)","startedAt":"2018-09-19T00:20:49Z","lastAt":"2018-09-21T16:27:13Z","messageCount":3,"participants":["Ramsay Jones","Junio C Hamano","Duy Nguyen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"358435","messageId":"c46ca4a9-6822-436c-8e84-95b977527912@ramsayjones.plus.com","threadId":"49378","inReplyTo":null,"subject":"[PATCH] userdiff.h: add missing declaration (hdr-check)","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-09-19T00:20:45Z","receivedAt":"2018-09-19T00:20:49Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Junio,\n\n... and this is the patch I needed for the current 'pu' branch.\n\nATB,\nRamsay Jones\n\n userdiff.h | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/userdiff.h b/userdiff.h\nindex dad3fc03c1..b072bfe89a 100644\n--- a/userdiff.h\n+++ b/userdiff.h\n@@ -3,6 +3,8 @@\n \n #include \"notes-cache.h\"\n \n+struct index_state;\n+\n struct userdiff_funcname {\n \tconst char *pattern;\n \tint cflags;\n-- \n2.19.0\n"},{"id":"358607","messageId":"xmqqworex1h7.fsf@gitster-ct.c.googlers.com","threadId":"49378","inReplyTo":"c46ca4a9-6822-436c-8e84-95b977527912@ramsayjones.plus.com","subject":"Re: [PATCH] userdiff.h: add missing declaration (hdr-check)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-21T16:24:36Z","receivedAt":"2018-09-21T16:24:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Junio,\n>\n> ... and this is the patch I needed for the current 'pu' branch.\n\nWhich in turn means that this is to fix 5b338d60 (\"userdiff.c:\nremove implicit dependency on the_index\", 2018-09-15) and should be\nrolled into nd/the_index topic.\n\n\n>\n> ATB,\n> Ramsay Jones\n>\n>  userdiff.h | 2 ++\n>  1 file changed, 2 insertions(+)\n>\n> diff --git a/userdiff.h b/userdiff.h\n> index dad3fc03c1..b072bfe89a 100644\n> --- a/userdiff.h\n> +++ b/userdiff.h\n> @@ -3,6 +3,8 @@\n>  \n>  #include \"notes-cache.h\"\n>  \n> +struct index_state;\n> +\n>  struct userdiff_funcname {\n>  \tconst char *pattern;\n>  \tint cflags;\n"},{"id":"358608","messageId":"CACsJy8DJ_PEJN_C_LJY4NNM6y1DbSy9vmgPOQTp3cPp0Ft+xEg@mail.gmail.com","threadId":"49378","inReplyTo":"xmqqworex1h7.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] userdiff.h: add missing declaration (hdr-check)","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-09-21T16:26:45Z","receivedAt":"2018-09-21T16:27:13Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Fri, Sep 21, 2018 at 6:24 PM Junio C Hamano <gitster@pobox.com> wrote:\n>\n> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n>\n> > Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> > ---\n> >\n> > Hi Junio,\n> >\n> > ... and this is the patch I needed for the current 'pu' branch.\n>\n> Which in turn means that this is to fix 5b338d60 (\"userdiff.c:\n> remove implicit dependency on the_index\", 2018-09-15) and should be\n> rolled into nd/the_index topic.\n\nI guess I should send v6 then?\n-- \nDuy\n"}]}