# [PATCH] userdiff.h: add missing declaration (hdr-check)

3 messages from 2018-09-19 to 2018-09-21. Participants: Ramsay Jones, Junio C Hamano, Duy Nguyen.
Thread: https://gitlist.dev/t/49378

## Ramsay Jones, 2018-09-19 00:20

Subject: [PATCH] userdiff.h: add missing declaration (hdr-check)
Message-ID: <c46ca4a9-6822-436c-8e84-95b977527912@ramsayjones.plus.com>
URL: https://gitlist.dev/e/c46ca4a9-6822-436c-8e84-95b977527912%40ramsayjones.plus.com

```

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Junio,

... and this is the patch I needed for the current 'pu' branch.

ATB,
Ramsay Jones

 userdiff.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/userdiff.h b/userdiff.h
index dad3fc03c1..b072bfe89a 100644
--- a/userdiff.h
+++ b/userdiff.h
@@ -3,6 +3,8 @@
 
 #include "notes-cache.h"
 
+struct index_state;
+
 struct userdiff_funcname {
 	const char *pattern;
 	int cflags;
-- 
2.19.0

```

## Junio C Hamano, 2018-09-21 16:24

Subject: Re: [PATCH] userdiff.h: add missing declaration (hdr-check)
Message-ID: <xmqqworex1h7.fsf@gitster-ct.c.googlers.com>
URL: https://gitlist.dev/e/xmqqworex1h7.fsf%40gitster-ct.c.googlers.com
In-Reply-To: <c46ca4a9-6822-436c-8e84-95b977527912@ramsayjones.plus.com>

```
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Junio,
>
> ... and this is the patch I needed for the current 'pu' branch.

Which in turn means that this is to fix 5b338d60 ("userdiff.c:
remove implicit dependency on the_index", 2018-09-15) and should be
rolled into nd/the_index topic.


>
> ATB,
> Ramsay Jones
>
>  userdiff.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/userdiff.h b/userdiff.h
> index dad3fc03c1..b072bfe89a 100644
> --- a/userdiff.h
> +++ b/userdiff.h
> @@ -3,6 +3,8 @@
>  
>  #include "notes-cache.h"
>  
> +struct index_state;
> +
>  struct userdiff_funcname {
>  	const char *pattern;
>  	int cflags;

```

## Duy Nguyen, 2018-09-21 16:26

Subject: Re: [PATCH] userdiff.h: add missing declaration (hdr-check)
Message-ID: <CACsJy8DJ_PEJN_C_LJY4NNM6y1DbSy9vmgPOQTp3cPp0Ft+xEg@mail.gmail.com>
URL: https://gitlist.dev/e/CACsJy8DJ_PEJN_C_LJY4NNM6y1DbSy9vmgPOQTp3cPp0Ft%2BxEg%40mail.gmail.com
In-Reply-To: <xmqqworex1h7.fsf@gitster-ct.c.googlers.com>

```
On Fri, Sep 21, 2018 at 6:24 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
> > Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> > ---
> >
> > Hi Junio,
> >
> > ... and this is the patch I needed for the current 'pu' branch.
>
> Which in turn means that this is to fix 5b338d60 ("userdiff.c:
> remove implicit dependency on the_index", 2018-09-15) and should be
> rolled into nd/the_index topic.

I guess I should send v6 then?
-- 
Duy

```