threads / discuss / 49103

function get_delta_base() is a file-local symbol

Subject: function get_delta_base() is a file-local symbol

## tl;dr

3 messages between Aug 12, 2018 and Aug 12, 2018.

replies: 2people: 3as markdown or json

Ramsay Jones· Aug 12, 2018, 00:30 UTC · lore
Hi Christian,

My static-check.pl script has pinged me about the get_delta_base() symbol from packfile.[co]. The first patch from your 'cc/delta-islands' branch exports this symbol, saying that it will soon be called from outside packfile.c. As far as I can tell, no other patch in that series adds any such call.

Do you have plans to extend that series with additional patches which will add such calls?

ATB, Ramsay Jones

Jeff King· Aug 12, 2018, 01:16 UTC · re: Ramsay Jones · lore

Re: function get_delta_base() is a file-local symbol

On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote:
Show 10 quoted lines
> Hi Christian,
> 
> My static-check.pl script has pinged me about the get_delta_base()
> symbol from packfile.[co]. The first patch from your 'cc/delta-islands'
> branch exports this symbol, saying that it will soon be called from
> outside packfile.c. As far as I can tell, no other patch in that series
> adds any such call.
> 
> Do you have plans to extend that series with additional patches which
> will add such calls?

Hmm, I think this is just my error. I had to untangle the delta island code from a few other topics, and I think I mistakenly attributed the need for get_delta_base() to the wrong topic. It can just be left alone for this series.

-Peff
Christian Couder· Aug 12, 2018, 03:53 UTC · re: Jeff King · lore

Re: function get_delta_base() is a file-local symbol

Hi Ramsay and Peff,
On Sun, Aug 12, 2018 at 3:16 AM, Jeff King <peff@peff.net> wrote:
Show 7 quoted lines
> On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote:
>
>> My static-check.pl script has pinged me about the get_delta_base()
>> symbol from packfile.[co]. The first patch from your 'cc/delta-islands'
>> branch exports this symbol, saying that it will soon be called from
>> outside packfile.c. As far as I can tell, no other patch in that series
>> adds any such call.
Yeah, I should have checked that but I didn't.
Thanks for noticing.
Show 7 quoted lines
>> Do you have plans to extend that series with additional patches which
>> will add such calls?
>
> Hmm, I think this is just my error. I had to untangle the delta island
> code from a few other topics, and I think I mistakenly attributed the
> need for get_delta_base() to the wrong topic. It can just be left alone
> for this series.
Ok, I will will remove the first patch in the next reroll. Thanks.

← back to recent threads