{"thread":{"id":"49103","subject":"function get_delta_base() is a file-local symbol","startedAt":"2018-08-12T00:30:09Z","lastAt":"2018-08-12T03:53:57Z","messageCount":3,"participants":["Ramsay Jones","Jeff King","Christian Couder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"355273","messageId":"b5b25177-38de-14ba-5d83-c8909ce0addd@ramsayjones.plus.com","threadId":"49103","inReplyTo":null,"subject":"function get_delta_base() is a file-local symbol","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-08-12T00:30:02Z","receivedAt":"2018-08-12T00:30:09Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Hi Christian,\n\nMy static-check.pl script has pinged me about the get_delta_base()\nsymbol from packfile.[co]. The first patch from your 'cc/delta-islands'\nbranch exports this symbol, saying that it will soon be called from\noutside packfile.c. As far as I can tell, no other patch in that series\nadds any such call.\n\nDo you have plans to extend that series with additional patches which\nwill add such calls?\n\nATB,\nRamsay Jones\n"},{"id":"355274","messageId":"20180812011612.GA10782@sigill.intra.peff.net","threadId":"49103","inReplyTo":"b5b25177-38de-14ba-5d83-c8909ce0addd@ramsayjones.plus.com","subject":"Re: function get_delta_base() is a file-local symbol","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2018-08-12T01:16:12Z","receivedAt":"2018-08-12T01:16:15Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote:\n\n> Hi Christian,\n> \n> My static-check.pl script has pinged me about the get_delta_base()\n> symbol from packfile.[co]. The first patch from your 'cc/delta-islands'\n> branch exports this symbol, saying that it will soon be called from\n> outside packfile.c. As far as I can tell, no other patch in that series\n> adds any such call.\n> \n> Do you have plans to extend that series with additional patches which\n> will add such calls?\n\nHmm, I think this is just my error. I had to untangle the delta island\ncode from a few other topics, and I think I mistakenly attributed the\nneed for get_delta_base() to the wrong topic. It can just be left alone\nfor this series.\n\n-Peff\n"},{"id":"355276","messageId":"CAP8UFD0KtVWtyAp1sBoLLCE5L5u6qH0VQ6Ng12Bopv+28Nnk1A@mail.gmail.com","threadId":"49103","inReplyTo":"20180812011612.GA10782@sigill.intra.peff.net","subject":"Re: function get_delta_base() is a file-local symbol","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2018-08-12T03:53:54Z","receivedAt":"2018-08-12T03:53:57Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Hi Ramsay and Peff,\n\nOn Sun, Aug 12, 2018 at 3:16 AM, Jeff King <peff@peff.net> wrote:\n> On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote:\n>\n>> My static-check.pl script has pinged me about the get_delta_base()\n>> symbol from packfile.[co]. The first patch from your 'cc/delta-islands'\n>> branch exports this symbol, saying that it will soon be called from\n>> outside packfile.c. As far as I can tell, no other patch in that series\n>> adds any such call.\n\nYeah, I should have checked that but I didn't.\n\nThanks for noticing.\n\n>> Do you have plans to extend that series with additional patches which\n>> will add such calls?\n>\n> Hmm, I think this is just my error. I had to untangle the delta island\n> code from a few other topics, and I think I mistakenly attributed the\n> need for get_delta_base() to the wrong topic. It can just be left alone\n> for this series.\n\nOk, I will will remove the first patch in the next reroll. Thanks.\n"}]}