git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: function get_delta_base() is a file-local symbol

From
Jeff King <peff@peff.net>
Date
Aug 12, 2018, 01:16 UTC
Message-ID
<20180812011612.GA10782@sigill.intra.peff.net>
In-Reply-To
<b5b25177-38de-14ba-5d83-c8909ce0addd@ramsayjones.plus.com>
On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote:
Show 10 quoted lines
> Hi Christian,
> 
> My static-check.pl script has pinged me about the get_delta_base()
> symbol from packfile.[co]. The first patch from your 'cc/delta-islands'
> branch exports this symbol, saying that it will soon be called from
> outside packfile.c. As far as I can tell, no other patch in that series
> adds any such call.
> 
> Do you have plans to extend that series with additional patches which
> will add such calls?

Hmm, I think this is just my error. I had to untangle the delta island code from a few other topics, and I think I mistakenly attributed the need for get_delta_base() to the wrong topic. It can just be left alone for this series.

-Peff
Previous: Ramsay JonesNext: Christian Couder
Message 2 of 3 in “function get_delta_base() is a file-local symbol”
  1. Ramsay JonesAug 12, 2018
  2. Jeff KingAug 12, 2018
  3. Christian CouderAug 12, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.